[Merged by Bors] - p2p: use decaying tags for fetch peers #5564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #5564 +/- ##
=========================================
+ Coverage 79.5% 79.7% +0.2%
=========================================
Files 268 267 -1
Lines 26591 26852 +261
=========================================
+ Hits 21145 21409 +264
- Misses 3917 3920 +3
+ Partials 1529 1523 -6 ☔ View full report in Codecov by Sentry. |
dshulyak
approved these changes
Feb 13, 2024
|
bors try |
tryBuild succeeded: |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Feb 14, 2024
## Motivation When there's some peer churn (connection manager enabled, which is the default), fetch can be interrupted by connection manager dropping connections which are currently used for fetching. This can happen both for fetch clients and servers, breaking sync.
|
Pull request successfully merged into develop. Build succeeded: |
spacemesh-bors
bot
changed the title
ivan4th
added a commit
that referenced
this pull request
Feb 14, 2024
When there's some peer churn (connection manager enabled, which is the default), fetch can be interrupted by connection manager dropping connections which are currently used for fetching. This can happen both for fetch clients and servers, breaking sync.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When there's some peer churn (connection manager enabled, which is the default), fetch can be interrupted by connection manager dropping connections which are currently used for fetching. This can happen both for fetch clients and servers, breaking sync.
Description
When a peer connection is used for any fetch request (both on client and server side), a decaying tag is applied to that peer so that the connection with it is kept for some time. After there are no fetch requests for a while (~10 min by default), the decaying tag is removed.
Test Plan
Verify sync