[Merged by Bors] - Remove in-code localDB migrations #5814
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5814 +/- ##
=========================================
+ Coverage 80.2% 80.4% +0.1%
=========================================
Files 286 283 -3
Lines 29789 29319 -470
=========================================
- Hits 23910 23575 -335
+ Misses 4229 4150 -79
+ Partials 1650 1594 -56 ☔ View full report in Codecov by Sentry. |
fasmat
reviewed
Apr 8, 2024
fasmat
reviewed
Apr 8, 2024
pigmej
approved these changes
Apr 8, 2024
ivan4th
reviewed
Apr 8, 2024
ivan4th
approved these changes
Apr 8, 2024
fasmat
reviewed
Apr 8, 2024
node/node_version_check.go
Outdated
| } | ||
|
|
||
| // v1.5 requires going through v1.4 first as it removed in-code migrations. | ||
| func verifyUpgradeToV15(cfg *config.Config) error { |
There was a problem hiding this comment.
This can probably be inlined, because if we require a higher version later we will just upgrade the version check on line 28 below instead of adding a new function.
fasmat
approved these changes
Apr 8, 2024
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Apr 10, 2024
## Motivation The code of migrations is not needed anymore, we will require to update to 1.4 before going to 1.5.
|
Pull request successfully merged into develop. Build succeeded: |
spacemesh-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The code of migrations is not needed anymore, we will require to update to 1.4 before going to 1.5.
Description
Removed in-code migrations for the local DB (migrating from files to DB and renaming the DB).
Test Plan
n/a
TODO