Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport] Avoid pulling poet proof multiple times in 1:N setups (#5911) #5914

Merged
merged 2 commits into from
May 7, 2024

Conversation

poszu
Copy link
Contributor

@poszu poszu commented May 7, 2024

Description

Backported #5911 to v1.5

Test Plan

n/a

TODO

  • Explain motivation or link existing issue(s)
  • Test changes and document test plan
  • Update documentation as needed
  • Update changelog as needed

All identities within the node register in the same poets so there's no need to fetch the proof many times.
Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 87.65432% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 80.4%. Comparing base (8d35429) to head (c1f9fb7).
Report is 1 commits behind head on v1.5.

Files Patch % Lines
activation/poet.go 89.3% 4 Missing and 3 partials ⚠️
activation/poetdb.go 71.4% 2 Missing ⚠️
common/types/poet.go 66.6% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            v1.5   #5914   +/-   ##
=====================================
  Coverage   80.4%   80.4%           
=====================================
  Files        285     285           
  Lines      29544   29579   +35     
=====================================
+ Hits       23769   23804   +35     
  Misses      4168    4168           
  Partials    1607    1607           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poszu poszu enabled auto-merge May 7, 2024 07:59
@poszu poszu merged commit 12df191 into v1.5 May 7, 2024
20 checks passed
@poszu poszu deleted the backport/1.5/5911 branch May 7, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants