Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Fix/6041 bug #6053

Closed
wants to merge 25 commits into from
Closed

[Merged by Bors] - Fix/6041 bug #6053

wants to merge 25 commits into from

Conversation

ConvallariaMaj
Copy link
Contributor

Motivation

Fix the bug

Description

Fix of issue #6041

Added timeout to context for searching positioning ATX, wrote couple new tests, extended offloadingPostVerifier.Verify() method to prioritize verificaiton of positioning ATX candidate.

Test Plan

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 91.56627% with 7 lines in your changes missing coverage. Please review.

Project coverage is 81.4%. Comparing base (f3c022a) to head (fa35dbd).
Report is 4 commits behind head on develop.

Files Patch % Lines
activation/activation.go 82.9% 5 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #6053     +/-   ##
=========================================
- Coverage     81.4%   81.4%   -0.1%     
=========================================
  Files          299     300      +1     
  Lines        32149   32196     +47     
=========================================
+ Hits         26200   26238     +38     
- Misses        4238    4245      +7     
- Partials      1711    1713      +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ConvallariaMaj ConvallariaMaj marked this pull request as ready for review June 20, 2024 08:14
activation/activation.go Outdated Show resolved Hide resolved
activation/activation.go Outdated Show resolved Hide resolved
activation/activation.go Outdated Show resolved Hide resolved
activation/activation.go Outdated Show resolved Hide resolved
activation/activation.go Outdated Show resolved Hide resolved
activation/activation_test.go Outdated Show resolved Hide resolved
activation/post_verifier.go Outdated Show resolved Hide resolved
config/mainnet.go Outdated Show resolved Hide resolved
activation/activation.go Outdated Show resolved Hide resolved
activation/activation.go Outdated Show resolved Hide resolved
Copy link
Contributor

@acud acud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I have a few minor comments.

activation/activation.go Outdated Show resolved Hide resolved
activation/activation.go Outdated Show resolved Hide resolved
activation/validation.go Show resolved Hide resolved
config/mainnet.go Show resolved Hide resolved
activation/activation.go Outdated Show resolved Hide resolved
activation/post_verifier.go Outdated Show resolved Hide resolved
activation/post_verifier_test.go Outdated Show resolved Hide resolved
@fasmat fasmat self-requested a review June 21, 2024 16:11
activation/activation.go Outdated Show resolved Hide resolved
activation/activation_test.go Outdated Show resolved Hide resolved
activation/activation.go Outdated Show resolved Hide resolved
activation/validation.go Outdated Show resolved Hide resolved
Copy link
Member

@fasmat fasmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm now, maybe @poszu and @acud want to take another look as well?

Copy link
Contributor

@acud acud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Minor comment about something that was already there but should be addressed at some point

activation/post_verifier.go Show resolved Hide resolved
activation/activation.go Outdated Show resolved Hide resolved
@fasmat
Copy link
Member

fasmat commented Jun 26, 2024

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Jun 26, 2024
## Motivation

Fix the bug  



Co-authored-by: ConvallariaMaj <majalis.conv@gmail.com>
@spacemesh-bors
Copy link

Build failed (retrying...):

spacemesh-bors bot pushed a commit that referenced this pull request Jun 26, 2024
## Motivation

Fix the bug  



Co-authored-by: ConvallariaMaj <majalis.conv@gmail.com>
@spacemesh-bors
Copy link

Pull request successfully merged into develop.

Build succeeded:

@spacemesh-bors spacemesh-bors bot changed the title Fix/6041 bug [Merged by Bors] - Fix/6041 bug Jun 26, 2024
@spacemesh-bors spacemesh-bors bot closed this Jun 26, 2024
@spacemesh-bors spacemesh-bors bot deleted the fix/6041-bug branch June 26, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants