Merge pull request #174 from spacemeshos/dont-keep-verifier-in-service

Reduce service memory requirements by not keeping randomx all the time
spacemeshos · Jan 3, 2024 · 3ef1ae5 · 3ef1ae5
2 parents 071ea55 + 947f1d1
commit 3ef1ae5
Show file tree

Hide file tree

Showing 9 changed files with 18 additions and 17 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -11,7 +11,7 @@ members = [
 
 [package]
 name = "post-rs"
-version = "0.6.2"
+version = "0.6.3"
 edition = "2021"
 
 [lib]

diff --git a/certifier/Cargo.toml b/certifier/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "certifier"
-version = "0.6.2"
+version = "0.6.3"
 edition = "2021"
 
 [dependencies]

diff --git a/ffi/Cargo.toml b/ffi/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "post-cbindings"
-version = "0.6.2"
+version = "0.6.3"
 edition = "2021"
 
 

diff --git a/initializer/Cargo.toml b/initializer/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "initializer"
-version = "0.6.2"
+version = "0.6.3"
 edition = "2021"
 
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

diff --git a/profiler/Cargo.toml b/profiler/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "profiler"
-version = "0.6.2"
+version = "0.6.3"
 edition = "2021"
 
 [dependencies]

diff --git a/scrypt-ocl/Cargo.toml b/scrypt-ocl/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "scrypt-ocl"
-version = "0.6.2"
+version = "0.6.3"
 edition = "2021"
 
 [dependencies]

diff --git a/service/Cargo.toml b/service/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "service"
-version = "0.6.2"
+version = "0.6.3"
 edition = "2021"
 
 [lib]

diff --git a/service/src/service.rs b/service/src/service.rs
@@ -34,7 +34,6 @@ pub struct PostService {
     pow_flags: RandomXFlag,
     proof_generation: Mutex<Option<ProofGenProcess>>,
 
-    verifier: Verifier,
     stop: Arc<AtomicBool>,
 }
 
@@ -55,7 +54,6 @@ impl PostService {
             nonces,
             threads,
             pow_flags,
-            verifier: Verifier::new(Box::new(PoW::new(RandomXFlag::get_recommended_flags())?)),
             stop: Arc::new(AtomicBool::new(false)),
         })
     }
@@ -115,7 +113,10 @@ impl crate::client::PostService for PostService {
     }
 
     fn verify_proof(&self, proof: &Proof, metadata: &ProofMetadata) -> eyre::Result<()> {
-        self.verifier
+        let pow_verifier =
+            PoW::new(RandomXFlag::get_recommended_flags()).context("creating PoW verifier")?;
+        let verifier = Verifier::new(Box::new(pow_verifier));
+        verifier
             .verify(proof, metadata, &self.cfg, &self.init_cfg)
             .wrap_err("verifying proof")
     }