Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix profiler for ARM #76

Merged
merged 2 commits into from
May 23, 2023
Merged

Fix profiler for ARM #76

merged 2 commits into from
May 23, 2023

Conversation

pigmej
Copy link
Member

@pigmej pigmej commented May 23, 2023 •
edited by poszu
Loading

Closes #73

Currently, the profiler is compiled WITHOUT hw aes acceleration for ARM.

That should fix it.

@pigmej pigmej requested review from brusherru and poszu May 23, 2023 08:27
github-actions[bot]
github-actions bot previously approved these changes May 23, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeball: LGTM! 👍

confidence: 0.95 | [dashboard]

@codecov
Copy link

codecov bot commented May 23, 2023 •
edited
Loading

Codecov Report

Merging #76 (88a619d) into main (9f7b5d7) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main     #76   +/-   ##
=====================================
  Coverage   98.1%   98.1%           
=====================================
  Files         12      12           
  Lines       1205    1205           
=====================================
  Hits        1183    1183           
  Misses        22      22

@pigmej pigmej mentioned this pull request May 23, 2023
Closed
@pigmej
Copy link
Member Author

pigmej commented May 23, 2023

@poszu I checked profiler that was built in the action, and it works fine.

@pigmej
Copy link
Member Author

pigmej commented May 23, 2023 

{
  "time_s": 10.555179583,
  "speed_gib_s": 1.4211032490777094
}

@github-actions github-actions bot dismissed their stale review May 23, 2023 11:54

confidence: 0.40 | [dashboard]

@poszu poszu changed the title Fix profiler for apple silicon Fix profiler for ARM May 23, 2023
@poszu poszu merged commit df8c1d3 into main May 23, 2023
@poszu poszu deleted the pigmej-patch-1 branch May 23, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poszu poszu poszu approved these changes

@github-actions GitHub Actions GitHub Actions left review comments

@brusherru brusherru Awaiting requested review from brusherru

Assignees
No one assigned
Labels
milestone/genesis
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

profiler release on M1/M2 does NOT use hw AES acceleration
2 participants
@pigmej @poszu