Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Report an issue screen #941

Merged
merged 7 commits into from Jul 21, 2022
Merged

feat: add Report an issue screen #941

merged 7 commits into from Jul 21, 2022

Conversation

maparr
Copy link
Contributor

@maparr maparr commented Jul 12, 2022

It closes #931

@spacemeshos spacemeshos deleted a comment from github-actions bot Jul 12, 2022
@maparr maparr self-assigned this Jul 12, 2022
Copy link
Member

@brusherru brusherru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the rest, it sends reports to the Sentry, so it works and this is already great!
Let's polish it a little bit and merge :)

app/components/common/Feedback.tsx Outdated Show resolved Hide resolved
app/components/common/Feedback.tsx Outdated Show resolved Hide resolved
app/components/common/Feedback.tsx Show resolved Hide resolved
@maparr maparr requested a review from brusherru July 12, 2022 22:27
feat: add env.local

fix: replace styles

fix: remove eventId for report dialog

fix: remove eventId for report dialog

fix: add uniq id for user feedback
@spacemeshos spacemeshos deleted a comment from github-actions bot Jul 12, 2022
@spacemeshos spacemeshos deleted a comment from github-actions bot Jul 12, 2022
@spacemeshos spacemeshos deleted a comment from github-actions bot Jul 12, 2022
@spacemeshos spacemeshos deleted a comment from github-actions bot Jul 12, 2022
@spacemeshos spacemeshos deleted a comment from github-actions bot Jul 12, 2022
Copy link
Member

@brusherru brusherru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It still collects all the bug reports under the same event in Sentry.
Can we distinct them somehow into different events? 🤔

Mb we can just get rid of eventId in options and let Sentry generate it? 🤔

@maparr
Copy link
Contributor Author

maparr commented Jul 13, 2022

@brusherru , I checked this moment, seems like because the info that we're sending from 1 computer and 1 env, is similar to what we are sending again and again. In User Feedback category, we will be having different right now
Screenshot 2022-07-13 at 11 31 55
but unfortunately for event , all User Feedbacks will be grouped
Screenshot 2022-07-13 at 11 32 53

so, because User Feedback for Sentry is different from what we are expecting to see in his admin panel, that's why we have a misunderstanding. The main goal I think to see all these issues and react to them.

@oriya
Copy link

oriya commented Jul 13, 2022

Is there anyway (must be) for this category to be sent as an email notification to a specific email?
We currently handle all "tech support" via Discord and an email address.
We gonna need current "tech support" to be able to get these notifications.
Alternatively, I guess we can give current tech-support access to Sentry and teach them to look for this grouping.
Thoughts / ideas?

@maparr
Copy link
Contributor Author

maparr commented Jul 13, 2022

@oriya , let me check how can I configure this pipeline so, discord + email or just email will be ok for us?

@oriya
Copy link

oriya commented Jul 13, 2022

email should be fine :) and thank you!

@maparr
Copy link
Contributor Author

maparr commented Jul 14, 2022

Hey @brusherru , the last changes have already been approved by @oriya, so what we have

  1. Client can send unique feedback only once by version ( it is called a fingerprint, it is how the Sentry identifies unique/not unique errors )
  2. Other events and messages grouped into 1 for this client
  3. Added Alert tracker, that finds new events with the specific match by event/message content, and I'm sending it to our support team where they can find any information.

Screenshot 2022-07-14 at 12 22 08

Screenshot 2022-07-14 at 12 21 57

4. For Other events I will be sending personal once a week or two, because, for duplicate events and messages I cannot define this alert, Sentry doesn't have such an event, on every event update 5. Cleaned up Sentry issues and grouped it, right now we have only a few issues that need to check, a few of them are Windows, that issue on which u working right now

@maparr maparr requested a review from brusherru July 15, 2022 08:02
Copy link
Member

@brusherru brusherru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maparr maparr merged commit 216f9bd into develop Jul 21, 2022
@maparr maparr deleted the report_an_issue_screen branch July 21, 2022 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 'Report an issue' screen or modal next to the app version
3 participants