Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Confirm password when creating wallet #62

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: Confirm password when creating wallet #62

wants to merge 1 commit into from

Conversation

0xjac
Copy link

@0xjac 0xjac commented Jul 12, 2023

Closes #61

lrettig
lrettig requested changes Jul 12, 2023
View reviewed changes
cmd/wallet.go Outdated
cobra.CheckErr(err)

if pass != confirm {
_, _ = fmt.Fprintln(os.Stderr, "Error: Passwords do not match.")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's use log.Fatalln instead, as below.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Fixed! I was trying to imitate cobra.CheckErr. I should have read further. 🤦

@lrettig lrettig added the Community Contribution Contribution from the open source community label Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrettig lrettig lrettig requested changes

Assignees
No one assigned
Labels
Community Contribution Contribution from the open source community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ask for wallet file password twice
2 participants
@0xjac @lrettig