-
-
Notifications
You must be signed in to change notification settings - Fork 965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a way to enable/disable verbose rust versioning #521
Added a way to enable/disable verbose rust versioning #521
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
It's been exactly a month. Any updates on getting this PR merged? 🙂 |
@Snuggle I don't exactly understand the reason why developer need to see verbose compiler version on every prompt. Is it really needed for Rust development? Don't get me wrong, we just don't want to make the prompt clampsy and bloated with potetially useless information 🙏 |
The rust section in This PR makes the prompt less cluttered as a default. |
Thanks for the clarification. @salmanulfarzy feel free to merge. |
* origin/4.0: (44 commits) 3.8.0 Support multiple files for COMPOSE_FILE in docker (spaceship-prompt#395) Add Terraform Workspace section (spaceship-prompt#542) Document kubecontext showing namepace (spaceship-prompt#566) Use Zsh field splitting instead of awk (spaceship-prompt#544) Add namespace to k8s section (spaceship-prompt#565) 3.7.2 Document go.mod detection in golang section Improve package version detection using jq, python and node (spaceship-prompt#441) Truncate .git directory and childs like normal directories (spaceship-prompt#417) Add option to toggle verbose rust version (spaceship-prompt#521) Change font suggestion: Fira Mono → Fira Code Support go.mod files and fix GOPATH matching (spaceship-prompt#559) Hide PR template guidance behind comments (spaceship-prompt#556) Document pyproject.toml in pyenv section (spaceship-prompt#551) 3.7.1 Recognize pyproject.toml when showing pyenv section (spaceship-prompt#550) Fix orderd list count on CONTRIBUTING page (spaceship-prompt#548) Add image in doc for powerline dir lock symbol (spaceship-prompt#517) Remove argument from char test shebang (spaceship-prompt#533) ...
Description
An expansion on pull request #520 to add a config option to toggle showing channel suffixes in the Rust version, if you do not use the stable branch. If you do use the stable branch, this config option doesn't change anything.
SHOW_RUST_VERBOSE_VERSION=true
R v1.30.0-nightly
/R v1.30.0-beta.11
SHOW_RUST_VERBOSE_VERSION=false
R v1.30.0
Close #186
Close #276