Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a way to enable/disable verbose rust versioning #521

Merged
merged 3 commits into from
Nov 21, 2018
Merged

Added a way to enable/disable verbose rust versioning #521

merged 3 commits into from
Nov 21, 2018

Conversation

Snuggle
Copy link
Contributor

@Snuggle Snuggle commented Oct 5, 2018

Description

An expansion on pull request #520 to add a config option to toggle showing channel suffixes in the Rust version, if you do not use the stable branch. If you do use the stable branch, this config option doesn't change anything.

SHOW_RUST_VERBOSE_VERSION=true
R v1.30.0-nightly / R v1.30.0-beta.11

SHOW_RUST_VERBOSE_VERSION=false
R v1.30.0

Close #186
Close #276

Copy link
Member

@salmanulfarzy salmanulfarzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@salmanulfarzy
Copy link
Member

One of the oldest open PR #186 was addressing the same issue, along with #276. Lets see what they think about this change.

// @alexcormier @dcluna

@salmanulfarzy salmanulfarzy added the new-feature A PR that implement feature (section, specific behavior, etc). label Oct 5, 2018
@Snuggle
Copy link
Contributor Author

Snuggle commented Nov 5, 2018

It's been exactly a month. Any updates on getting this PR merged? 🙂

@salmanulfarzy
Copy link
Member

It's been exactly a month. Any updates on getting this PR merged?

This seems better solution than #186 and #276. So I would be more than happy to merge this.

But to add new options, we try to get approval from minimum two collaborators or contributors of relevant sections. Until that we've to wait.

@denysdovhan
Copy link
Member

@Snuggle I don't exactly understand the reason why developer need to see verbose compiler version on every prompt. Is it really needed for Rust development?

Don't get me wrong, we just don't want to make the prompt clampsy and bloated with potetially useless information 🙏

@Snuggle
Copy link
Contributor Author

Snuggle commented Nov 20, 2018

The rust section in master right now, is always verbose, this PR simplifies it and adds an option to keep verbose versioning, if wanted. (Might not be used often, but configurability is awesome!)

This PR makes the prompt less cluttered as a default.
I agree, not everyone needs to see the extra information, this fixes that. 🙂

@denysdovhan
Copy link
Member

Thanks for the clarification. @salmanulfarzy feel free to merge.

@salmanulfarzy salmanulfarzy merged commit 6792870 into spaceship-prompt:master Nov 21, 2018
salmanulfarzy added a commit to salmanulfarzy/spaceship-prompt that referenced this pull request Nov 23, 2018
* origin/4.0: (44 commits)
  3.8.0
  Support multiple files for COMPOSE_FILE in docker (spaceship-prompt#395)
  Add Terraform Workspace section (spaceship-prompt#542)
  Document kubecontext showing namepace (spaceship-prompt#566)
  Use Zsh field splitting instead of awk (spaceship-prompt#544)
  Add namespace to k8s section (spaceship-prompt#565)
  3.7.2
  Document go.mod detection in golang section
  Improve package version detection using jq, python and node (spaceship-prompt#441)
  Truncate .git directory and childs like normal directories (spaceship-prompt#417)
  Add option to toggle verbose rust version (spaceship-prompt#521)
  Change font suggestion: Fira Mono → Fira Code
  Support go.mod files and fix GOPATH matching (spaceship-prompt#559)
  Hide PR template guidance behind comments (spaceship-prompt#556)
  Document pyproject.toml in pyenv section (spaceship-prompt#551)
  3.7.1
  Recognize pyproject.toml when showing pyenv section (spaceship-prompt#550)
  Fix orderd list count on CONTRIBUTING page (spaceship-prompt#548)
  Add image in doc for powerline dir lock symbol (spaceship-prompt#517)
  Remove argument from char test shebang (spaceship-prompt#533)
  ...
dedene pushed a commit to zenjoy/spaceship-prompt that referenced this pull request Feb 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature A PR that implement feature (section, specific behavior, etc).
Development

Successfully merging this pull request may close these issues.

None yet

3 participants