Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognize pyproject.toml when showing pyenv section #550

Merged
merged 2 commits into from
Nov 7, 2018
Merged

Recognize pyproject.toml when showing pyenv section #550

merged 2 commits into from
Nov 7, 2018

Conversation

richin13
Copy link
Contributor

@richin13 richin13 commented Nov 6, 2018

Description

With this PR, the prompt shows pyenv section whenever it finds a pyproject.toml file in the cwd. This file belongs to python projects (see PEP-518/#specification and tools like Poetry use the file to store the build instructions and requirements

Screenshot

spaceship-prompt

sections/pyenv.zsh Outdated Show resolved Hide resolved
@salmanulfarzy salmanulfarzy added the improvement A PR that make small changes for improving UX, performance, readability, etc label Nov 7, 2018
Copy link
Member

@salmanulfarzy salmanulfarzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@salmanulfarzy salmanulfarzy merged commit c372891 into spaceship-prompt:master Nov 7, 2018
@salmanulfarzy
Copy link
Member

This has to be documented in the section.

@richin13
Copy link
Contributor Author

richin13 commented Nov 7, 2018

I'll add that in a different PR 😅
Thank you

salmanulfarzy added a commit to salmanulfarzy/spaceship-prompt that referenced this pull request Nov 23, 2018
* origin/4.0: (44 commits)
  3.8.0
  Support multiple files for COMPOSE_FILE in docker (spaceship-prompt#395)
  Add Terraform Workspace section (spaceship-prompt#542)
  Document kubecontext showing namepace (spaceship-prompt#566)
  Use Zsh field splitting instead of awk (spaceship-prompt#544)
  Add namespace to k8s section (spaceship-prompt#565)
  3.7.2
  Document go.mod detection in golang section
  Improve package version detection using jq, python and node (spaceship-prompt#441)
  Truncate .git directory and childs like normal directories (spaceship-prompt#417)
  Add option to toggle verbose rust version (spaceship-prompt#521)
  Change font suggestion: Fira Mono → Fira Code
  Support go.mod files and fix GOPATH matching (spaceship-prompt#559)
  Hide PR template guidance behind comments (spaceship-prompt#556)
  Document pyproject.toml in pyenv section (spaceship-prompt#551)
  3.7.1
  Recognize pyproject.toml when showing pyenv section (spaceship-prompt#550)
  Fix orderd list count on CONTRIBUTING page (spaceship-prompt#548)
  Add image in doc for powerline dir lock symbol (spaceship-prompt#517)
  Remove argument from char test shebang (spaceship-prompt#533)
  ...
dedene pushed a commit to zenjoy/spaceship-prompt that referenced this pull request Feb 24, 2019
…#550)

pyproject.toml specifies what build dependencies project have in order to
execute their chosen build system. Tools like Poetry[1] use the file to store
the build instructions and requirements. See PEP-518[2] for more

[1]: https://github.com/sdispater/poetry
[2]: https://www.python.org/dev/peps/pep-0518/#file-format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement A PR that make small changes for improving UX, performance, readability, etc
Development

Successfully merging this pull request may close these issues.

None yet

2 participants