Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor workflow to install from build configuration and use pytest and tox #218

Merged
merged 10 commits into from
Jan 5, 2023

Conversation

zacharyburnett
Copy link
Collaborator

@zacharyburnett zacharyburnett commented Dec 29, 2022

This PR refactors the workflow CI to run on push to master or on a pull request, and additionally uses tox to run lint / build checks before running tests with pytest-xdist.

image

blocked by #217:

AttributeError: module 'numpy' has no attribute 'int'. Did you mean: 'inf'?

@zacharyburnett zacharyburnett self-assigned this Dec 29, 2022
@zacharyburnett zacharyburnett changed the title refactor workflow to install from build configuration and use pytest refactor workflow to install from build configuration and use pytest and tox Dec 29, 2022
@codecov
Copy link

codecov bot commented Dec 29, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@d4e1c66). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #218   +/-   ##
=========================================
  Coverage          ?   87.17%           
=========================================
  Files             ?       17           
  Lines             ?     1333           
  Branches          ?        0           
=========================================
  Hits              ?     1162           
  Misses            ?      171           
  Partials          ?        0           
Flag Coverage Δ
unit 87.17% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This package is not my turf so I'll refrain from review. Feel free to ping me though for specific questions. Thanks!

@zacharyburnett zacharyburnett marked this pull request as ready for review December 30, 2022 13:34
Copy link
Contributor

@stscirij stscirij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont have any experience with tox, and almost none with github actions, but it looks like the tests pass so looks good to me

@zacharyburnett zacharyburnett merged commit 78cca9f into spacetelescope:master Jan 5, 2023
@zacharyburnett zacharyburnett deleted the ci_refactor branch January 5, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants