-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor workflow to install from build configuration and use pytest
and tox
#218
refactor workflow to install from build configuration and use pytest
and tox
#218
Conversation
eb898f1
to
5ad29c4
Compare
pytest
pytest
and tox
86fb129
to
095e83e
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #218 +/- ##
=========================================
Coverage ? 87.17%
=========================================
Files ? 17
Lines ? 1333
Branches ? 0
=========================================
Hits ? 1162
Misses ? 171
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This package is not my turf so I'll refrain from review. Feel free to ping me though for specific questions. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont have any experience with tox, and almost none with github actions, but it looks like the tests pass so looks good to me
This PR refactors the workflow CI to run on push to
master
or on a pull request, and additionally usestox
to run lint / build checks before running tests withpytest-xdist
.blocked by #217: