move build configuration into pyproject.toml
#216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zacharyburnett
requested review from
WilliamJamieson,
nden,
pllim and
stscirij
|
converting to draft to work on building C extension under PEP517; should be tested with #218 |
zacharyburnett
force-pushed
the
consolidate_build_config
branch
from
588576d
to
f3c79f2
Compare
Codecov ReportBase: 87.17% // Head: 87.17% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #216 +/- ##
=======================================
Coverage 87.17% 87.17%
=======================================
Files 17 17
Lines 1333 1333
=======================================
Hits 1162 1162
Misses 171 171
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
zacharyburnett
force-pushed
the
consolidate_build_config
branch
from
6e59c3e
to
6f630c3
Compare
stscirij
reviewed
Feb 9, 2023
stscirij
approved these changes
Feb 9, 2023
zacharyburnett
force-pushed
the
consolidate_build_config
branch
from
49b1e7c
to
91b0798
Compare
|
temporarily reverting this PR due to suspected involvement in https://jira.stsci.edu/browse/SPB-1432 |
zacharyburnett
added a commit
to zacharyburnett/calcos
that referenced
this pull request
Jul 11, 2023
stscirij
pushed a commit
that referenced
this pull request
Jul 12, 2023
This reverts commit 9af631f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in line with PEP621, with the new
setuptools; this also future-proofs against uses of a PEP517 build like in the new Tox update