Revert "move build configuration into pyproject.toml (#216)"
#229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #229 +/- ##
=======================================
Coverage 87.63% 87.63%
=======================================
Files 17 17
Lines 1391 1391
=======================================
Hits 1219 1219
Misses 172 172
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Hopefully this resolves the issue. After merging this PR we'll have to start the HCALDP job again and then we'll see |
mdlpstsci
approved these changes
Jul 11, 2023
|
Will try and fix the readthedocs build error in the next PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 9af631f due to suspected involvement in https://jira.stsci.edu/browse/SPB-1432
It appears that the HCALDP build was explicitly relying on
calcosto providepytestas a dependency, and sincecalcos's metadata is not parsed correctly for some reason, and the only difference seems to be using PEP621 (setup.py->pyproject.toml), we are reverting the PEP621 change for now.