Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pars-darkcurrentstep rmaps for NIRISS, NIRCAM and NIRSPEC. #1045

Merged
merged 4 commits into from
Jun 11, 2024

Conversation

hbrown-ST
Copy link
Collaborator

This PR handles CCD-1467 which added 3 rmaps for the pars-darkcurrentstep reference type.

@hbrown-ST hbrown-ST self-assigned this Jun 10, 2024
@hbrown-ST hbrown-ST requested a review from a team as a code owner June 10, 2024 16:23
Copy link
Collaborator

@alphasentaurii alphasentaurii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the combined_specs.json file be updated as well? Usually this is done by running './install' inside the crds repo top level directory

@hbrown-ST
Copy link
Collaborator Author

Should the combined_specs.json file be updated as well? Usually this is done by running './install' inside the crds repo top level directory

Yes that had not been done yet, thanks.

@hbrown-ST hbrown-ST merged commit bab1956 into master Jun 11, 2024
10 checks passed
@hbrown-ST hbrown-ST deleted the CCD-1467 branch June 11, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants