Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message has bad syntax #51

Closed
rjavila opened this issue Mar 28, 2017 · 2 comments
Closed

Error message has bad syntax #51

rjavila opened this issue Mar 28, 2017 · 2 comments
Assignees
Labels

Comments

@rjavila
Copy link

rjavila commented Mar 28, 2017

A user was trying to run some WFPC2 images through astrodrizzle and got the message below. They complained that the syntax in the error message was wrong (missing quotes in the updatewcs call). The message should also be updated to use astropy.io.fits instead of iraf tasks. Also, typing 'c' gives you a message that 'c' is not defined.

A 'DGEOFILE' keyword is present in the primary header but 'NPOLFILE' keyword was not found.
            This version of the software uses a new format for the residual distortion DGEO files.
            Please consult the instrument web pages for which reference files to download.
            A small (new style) dgeofile is needed ('_npl.fits' extension) and possibly a
            detector to image correction file ('_d2i.fits' extension).
            The names of these files must be added to the primary header either using the task XXXX
            or manually, for example:

            hedit u33z0401t_c0m.fits[0] npolfile fname_npl.fits add+
            hedit u33z0401t_c0m.fits[0] d2imfile fname_d2i.fits add+

            where fname_npl.fits is the name of the new style dgeo file and fname_d2i.fits is
            the name of the detector to image correction. After adding these keywords to the
            primary header, updatewcs must be run to update the science files:

            from stwcs import updatewcs
            updatewcs.updatewcs(u33z0401t_c0m.fits)

            Alternatively you may choose to run astrodrizzle without DGEO and detector to image correction.

            To stop astrodrizzle and update the dgeo files, type 'q'.
            To continue running astrodrizzle without the non-polynomial distortion correction, type 'c':
@mcara
Copy link
Member

mcara commented Mar 28, 2017

@rjavila This problem should be fixed in #53

If this is not an emergency, the fix will be made available with the next release of the drizzlepac.

Thanks for reporting the problem.

@mcara
Copy link
Member

mcara commented Apr 6, 2017

A bug-fix release for drizzlepac was made today and should be available for download tomorrow. Closing this issue...

@mcara mcara closed this as completed Apr 6, 2017
s-goldman pushed a commit to s-goldman/drizzlepac that referenced this issue Sep 5, 2024
* add all builds to sonarqube

* Add branch scanning to hstcal build action

* Add wrapped builds for sonarqube-pr workflow

* Add POC workflow call to drizzlepac

* Allow forked builds for romancal sonarscan builder action

* Allow forked builds for romanisim sonarscan builder action

* Allow forked builds for crds_client sonarscan builder action

* Allow forked builds for calcos sonarscan builder action

* Allow forked builds for jwst sonarscan builder action

* use correct package

* use correct package in crds

* test consolidated workflow with drizzlepac

* dont explicitly refer to package

* remove if statement

* add all inputs to workflow call to match workflow_dispatch

* pull out branch parameter

* readd branch

* set project base to main

* add new line

* try with scm exclusions

* try to run within the pulled directory

* copy project properties into directory

* path to build wrapper output

* path to report-task

* skip test for now

* try encoded url

* try encoded url

* try analysis cache false

* open results in new tab

* remove and

* echo results in markdown

* use ref instead of branch for clarity

* enclose in quotes

* quotes

* try setting project base directory

* add scanner file

* try scm exclusions disable

* up log level

* try explicit sources declaration

* try origin prepend

* only origin on base

* remove debug

* add \

* more general build

* more general build for all builds

* Add workflow call to other packages

* Add default git url to inputs

* Add defaults to branch input

* Use giturl and ref in scan and test jobs

* use pr sonarqube on this branch for testing.  To be reverted before merge.

* Dev PR workflow

* add new arguments to workflow_calls to match workflow_dispatch

* Need to remove some inputs to get down to 10 inputs.

* overwrite sonarqube with the pr version

* use sonarqube @ dev-pr-workflow.  To be pointed back to main

* have example workflows deploy romancal

* sonarqube file change for crds_client

* remove hardcoded drizzlepac in sonarscan

* same updates for sonarqube-pr as sonarqube

* Use inputs.git_url not inputs.repo

* git_ref not ref

* few typos

* Run sonarscan as branch

* Differentiate between normal or forked repo and scan as branch or PR

* Use full url

* Bash if statement

* Check if forked repo

* Add other checks for forked repo in builds

* test

* new pr key

* New pr key

* Display scan url for pr or branch

* remove some encoding that confuses github

* always display results url

* remove old pr workflow

* Point sonarscan workflow ref back to main

* Update .github/workflows/jwst.yml

Co-authored-by: Zach Burnett <zburnett@stsci.edu>

* Update .github/workflows/romancal.yml

Co-authored-by: Zach Burnett <zburnett@stsci.edu>

---------

Co-authored-by: George Cleary <gcleary@stsci.edu>
Co-authored-by: Zach Burnett <zburnett@stsci.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants