Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APE 14 says return for pixel_to_world should not be a tuple if 1D #332

Merged
merged 1 commit into from
Nov 20, 2020
Merged

APE 14 says return for pixel_to_world should not be a tuple if 1D #332

merged 1 commit into from
Nov 20, 2020

Conversation

Cadair
Copy link
Collaborator

@Cadair Cadair commented Nov 19, 2020

We already have equivalent code for world_to_pixel, but not in this direction apparently

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 91.119% when pulling f198b48 on Cadair:ape_14_return into 7e2dbea on spacetelescope:master.

@nden nden merged commit 45f6515 into spacetelescope:master Nov 20, 2020
@Cadair Cadair deleted the ape_14_return branch November 20, 2020 21:05
@nden nden added this to the 0.16 milestone Dec 18, 2020
@nden
Copy link
Collaborator

nden commented Dec 20, 2020

This change caused a regression reported in #341

@nden nden mentioned this pull request Dec 20, 2020
Merged
@Cadair
Copy link
Collaborator Author

Cadair commented Dec 21, 2020

Whoops, sorry :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nden nden nden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.16
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Cadair @coveralls @nden