Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "APE 14 says return for pixel_to_world should not be a tuple if 1D" #342

Merged
merged 1 commit into from Dec 20, 2020

Conversation

nden
Copy link
Collaborator

@nden nden commented Dec 20, 2020

Reverts #332 which caused the regression reported in #341.

A simple test with SpectralFrame shows the output of pixel_to_world works as expected without this change. @Cadair you must have run into a problem using a different Frame. Please file an issue with your failing example.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 90.814% when pulling 60d1bc6 on revert-332-ape_14_return into 0a54327 on master.

@nden nden merged commit 2825484 into master Dec 20, 2020
@jdavies-st jdavies-st deleted the revert-332-ape_14_return branch September 2, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants