Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multi-dimensional world_axis_object_components/classes with CoordinateFrame #356

Merged
merged 3 commits into from
Mar 29, 2021

Conversation

Cadair
Copy link
Collaborator

@Cadair Cadair commented Mar 4, 2021

I discovered this while working on some NDCube stuff for making a WCS with 3 distance (km) axes. We need this for the NDCube 2 release. 😄

Fixes #358

@Cadair Cadair force-pushed the waoc_base_frame branch 2 times, most recently from bc38a95 to 4e2a3cb Compare March 4, 2021 16:29
@codecov
Copy link

codecov bot commented Mar 4, 2021

Codecov Report

Merging #356 (0ff3814) into master (b34be78) will increase coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #356      +/-   ##
==========================================
+ Coverage   90.23%   90.38%   +0.15%     
==========================================
  Files          32       32              
  Lines        5006     5066      +60     
==========================================
+ Hits         4517     4579      +62     
+ Misses        489      487       -2     
Impacted Files Coverage Δ
gwcs/coordinate_frames.py 95.12% <100.00%> (+0.87%) ⬆️
gwcs/tests/conftest.py 88.31% <100.00%> (+0.39%) ⬆️
gwcs/tests/test_api.py 98.01% <100.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b34be78...0ff3814. Read the comment docs.

@nden
Copy link
Collaborator

nden commented Mar 12, 2021

LGTM.
@Cadair Can you rebase?

@Cadair
Copy link
Collaborator Author

Cadair commented Mar 12, 2021

@nden can you hold off merging this for a bit, I want to poke at #358 to see what the overlap is.

@Cadair
Copy link
Collaborator Author

Cadair commented Mar 12, 2021

ok @nden I have now updated this to also fix #358 I did it in one go to minimise the sillyness of appending integers to the names of the objects.

If you can see a better way of doing the deduplication please let me know, my brain isn't exactly on peak form this week.

@nden nden merged commit 14a8c0b into spacetelescope:master Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CompositeFrame does not deduplicate keys in world_axis_object_classes
2 participants