Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

greater transparency between glue/widget components and underlying data #4

Closed
havok2063 opened this issue May 9, 2019 · 4 comments
Closed

greater transparency between glue/widget components and underlying data #4

havok2063 opened this issue May 9, 2019 · 4 comments

Comments

@havok2063
Copy link
Collaborator

The underlying data gets lost somewhere inside the glue/widget components. It's not clear how to get back the underlying FITS data. This is useful in general but will also be necessary I think to implement the "point-and-click" spaxel view and to extract info for display in hover tooltips.

For example, using the cubeviz example notebook, I can access the glue Data container which contains limited data components. Similarly, a (limited?) header appears inside data.meta but meta isn't mentioned anywhere in the documentation on glue Data objects. I discovered it by accident.

imlayerstate = c._v3d._v3d.state.layers[0]
data = imlayerstate.layer
flux = data.components[-1]
flux_data = data[flux]
hdr_data = data.meta

It might be useful to store the full original data HDU somewhere inside the container or widget and make it transparent as to how to retrieve it.
@brechmos-stsci
Copy link
Contributor

Completely agree. This is going to be a bit of a change in this code and some more transparency in the glue-jupyter / glue-core code. I will take a look at this a bit more.

@stscijgbot
Copy link

This ticket is now being tracked at DATJPP-94

@astrofrog
Copy link
Collaborator

Related glue-jupyter issue and discussion: glue-viz/glue-jupyter#30

@spacetelescope spacetelescope deleted a comment from stscijgbot May 29, 2019
@SaOgaz
Copy link
Contributor

SaOgaz commented Jun 19, 2019

See above link for further discussion.

@SaOgaz SaOgaz closed this as completed Jun 19, 2019
javerbukh pushed a commit that referenced this issue Sep 15, 2020
@ibusko
Merge pull request #4 from rosteen/statistic-fix
3fc400b 
Statistic fix
javerbukh pushed a commit that referenced this issue Oct 12, 2020
@PatrickOgle
Merge pull request #4 from spacetelescope/master
ce8f2e3 
Update fork
mariobuikhuizen pushed a commit to mariobuikhuizen/jdaviz that referenced this issue May 18, 2021
@javerbukh
Merge pull request spacetelescope#4 from mariobuikhuizen/fix_height_o…
ffff083 
…n_viewer_bar

fix: make viewer bar + viewer fit the available height
rosteen pushed a commit that referenced this issue Aug 17, 2021
@astrofrog
Merge pull request #4 from rosteen/astrofrog-speed-up-mosviz-loading
e7935d8 
Added a quick NIRISS parser test
pllim added a commit that referenced this issue Dec 1, 2021
@pllim
Merge pull request #4 from kecnry/pixel-div-vert-centered
4120379 
Attempt to fix vertical padding on pixel coordinate div in imviz
duytnguyendtn referenced this issue in duytnguyendtn/jdaviz Jun 12, 2023
@pllim @bmorris3
Proposed changes for PR 2179 (ENH: Image rotation via WCS-only layers) (
6db984c 
#4)

* Lim edits

* Improve verbiage in docstring

Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com>

* Address review comments from bmorris3

* Add multi WCS-only test back

* Update concept notebook

* corrections to the pr to the pr to the pr (spacetelescope#10)

* corrections to the pr to the pr to the pr

* using app-level attr

* Update jdaviz/configs/imviz/plugins/parsers.py

Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>

* Update jdaviz/configs/imviz/plugins/parsers.py

Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>

---------

Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>

* Follow up to PR to my PR to your PR

* WCS-only must be loaded
into viewer but not visible.

Fix concept notebook

---------

Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com>
kecnry referenced this issue in kecnry/jdaviz Jul 28, 2023
@pllim @bmorris3
Proposed changes for PR 2179 (ENH: Image rotation via WCS-only layers) (
f1831d2 
#4)

* Lim edits

* Improve verbiage in docstring

Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com>

* Address review comments from bmorris3

* Add multi WCS-only test back

* Update concept notebook

* corrections to the pr to the pr to the pr (spacetelescope#10)

* corrections to the pr to the pr to the pr

* using app-level attr

* Update jdaviz/configs/imviz/plugins/parsers.py

Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>

* Update jdaviz/configs/imviz/plugins/parsers.py

Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>

---------

Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>

* Follow up to PR to my PR to your PR

* WCS-only must be loaded
into viewer but not visible.

Fix concept notebook

---------

Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com>
kecnry referenced this issue in kecnry/jdaviz Aug 1, 2023
@duytnguyendtn
Merge pull request #4 from kecnry/launcher-tooltip
434de8c 
launcher on file-dialog button
kecnry referenced this issue in kecnry/jdaviz Aug 8, 2023
@pllim @bmorris3
Proposed changes for PR 2179 (ENH: Image rotation via WCS-only layers) (
4e18338 
#4)

* Lim edits

* Improve verbiage in docstring

Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com>

* Address review comments from bmorris3

* Add multi WCS-only test back

* Update concept notebook

* corrections to the pr to the pr to the pr (spacetelescope#10)

* corrections to the pr to the pr to the pr

* using app-level attr

* Update jdaviz/configs/imviz/plugins/parsers.py

Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>

* Update jdaviz/configs/imviz/plugins/parsers.py

Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>

---------

Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>

* Follow up to PR to my PR to your PR

* WCS-only must be loaded
into viewer but not visible.

Fix concept notebook

---------

Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com>
cshanahan1 pushed a commit to cshanahan1/jdaviz that referenced this issue Nov 8, 2023
@pllim @bmorris3
Proposed changes for PR 2179 (ENH: Image rotation via WCS-only layers) (
8daf210 
spacetelescope#4)

* Lim edits

* Improve verbiage in docstring

Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com>

* Address review comments from bmorris3

* Add multi WCS-only test back

* Update concept notebook

* corrections to the pr to the pr to the pr (spacetelescope#10)

* corrections to the pr to the pr to the pr

* using app-level attr

* Update jdaviz/configs/imviz/plugins/parsers.py

Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>

* Update jdaviz/configs/imviz/plugins/parsers.py

Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>

---------

Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>

* Follow up to PR to my PR to your PR

* WCS-only must be loaded
into viewer but not visible.

Fix concept notebook

---------

Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com>
cshanahan1 pushed a commit to cshanahan1/jdaviz that referenced this issue Nov 15, 2023
@pllim @bmorris3
Proposed changes for PR 2179 (ENH: Image rotation via WCS-only layers) (
253a69a 
spacetelescope#4)

* Lim edits

* Improve verbiage in docstring

Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com>

* Address review comments from bmorris3

* Add multi WCS-only test back

* Update concept notebook

* corrections to the pr to the pr to the pr (spacetelescope#10)

* corrections to the pr to the pr to the pr

* using app-level attr

* Update jdaviz/configs/imviz/plugins/parsers.py

Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>

* Update jdaviz/configs/imviz/plugins/parsers.py

Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>

---------

Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>

* Follow up to PR to my PR to your PR

* WCS-only must be loaded
into viewer but not visible.

Fix concept notebook

---------

Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com>
pllim added a commit that referenced this issue Jan 23, 2024
@pllim @bmorris3
Proposed changes for PR 2179 (ENH: Image rotation via WCS-only layers) (
e20be3d 
#4)

* Lim edits

* Improve verbiage in docstring

Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com>

* Address review comments from bmorris3

* Add multi WCS-only test back

* Update concept notebook

* corrections to the pr to the pr to the pr (#10)

* corrections to the pr to the pr to the pr

* using app-level attr

* Update jdaviz/configs/imviz/plugins/parsers.py

Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>

* Update jdaviz/configs/imviz/plugins/parsers.py

Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>

---------

Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>

* Follow up to PR to my PR to your PR

* WCS-only must be loaded
into viewer but not visible.

Fix concept notebook

---------

Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com>
gibsongreen pushed a commit to gibsongreen/jdaviz that referenced this issue Feb 12, 2024
@pllim @bmorris3 @gibsongreen
Proposed changes for PR 2179 (ENH: Image rotation via WCS-only layers) (
5363694 
spacetelescope#4)

* Lim edits

* Improve verbiage in docstring

Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com>

* Address review comments from bmorris3

* Add multi WCS-only test back

* Update concept notebook

* corrections to the pr to the pr to the pr (spacetelescope#10)

* corrections to the pr to the pr to the pr

* using app-level attr

* Update jdaviz/configs/imviz/plugins/parsers.py

Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>

* Update jdaviz/configs/imviz/plugins/parsers.py

Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>

---------

Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>

* Follow up to PR to my PR to your PR

* WCS-only must be loaded
into viewer but not visible.

Fix concept notebook

---------

Co-authored-by: Brett M. Morris <morrisbrettm@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@astrofrog @havok2063 @SaOgaz @brechmos-stsci @stscijgbot