Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Use bqplot dev from master branch #1776

Merged
merged 2 commits into from
Aug 18, 2023
Merged

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Oct 25, 2022

Description

This pull request is to install bqplot dev from its master branch again instead of 0.12.x branch. This would future-proof against incompatibility with 0.13.x when that happens.

Fixes #955

Blocked by

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@pllim pllim added Upstream fix required trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive labels Oct 25, 2022
@pllim pllim added this to the 3.1 milestone Oct 25, 2022
@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Patch coverage has no change and project coverage change: -2.81% ⚠️

Comparison is base (4e262f9) 90.61% compared to head (21d02fe) 87.81%.

❗ Current head 21d02fe differs from pull request most recent head 2256a0f. Consider uploading reports for the commit 2256a0f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1776      +/-   ##
==========================================
- Coverage   90.61%   87.81%   -2.81%     
==========================================
  Files         159       95      -64     
  Lines       18177    10165    -8012     
==========================================
- Hits        16471     8926    -7545     
+ Misses       1706     1239     -467     

see 127 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rosteen rosteen modified the milestones: 3.1, 3.2 Oct 26, 2022
@rosteen rosteen modified the milestones: 3.2, 3.3 Jan 4, 2023
@rosteen rosteen modified the milestones: 3.3, 3.4 Feb 9, 2023
@rosteen rosteen modified the milestones: 3.4, 3.5 Mar 22, 2023
@haticekaratay haticekaratay modified the milestones: 3.5, 3.6 May 25, 2023
@javerbukh javerbukh modified the milestones: 3.6, 3.7 Jul 28, 2023
@pllim pllim marked this pull request as ready for review August 18, 2023 01:23
@pllim
Copy link
Contributor Author

pllim commented Aug 18, 2023

This dragged on long enough, let's do it.

@pllim pllim merged commit 90ddefb into spacetelescope:main Aug 18, 2023
14 checks passed
@pllim pllim deleted the bqplot-dev branch August 18, 2023 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed changelog bot directive testing trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI test fails: Python 3.9 with latest dev versions
4 participants