Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC: Attempt to package jdaviz in Pyinstaller (take 2) #1960

Merged
merged 89 commits into from
Jul 5, 2023

Commits on May 16, 2023

  1. feat: pyinstaller

    duytnguyendtn authored and maartenbreddels committed May 16, 2023
    Configuration menu
    Copy the full SHA
    f760572 View commit details
    Browse the repository at this point in the history
  2. codesign osx

    maartenbreddels committed May 16, 2023
    Configuration menu
    Copy the full SHA
    b520aef View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    58730c3 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2023

  1. Configuration menu
    Copy the full SHA
    47f966b View commit details
    Browse the repository at this point in the history
  2. use hooks

    maartenbreddels committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    2f9041a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5569a4c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ba8ee5a View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2023

  1. better hooks

    maartenbreddels committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    ef4b254 View commit details
    Browse the repository at this point in the history
  2. pin to 5.11

    Otherwise we need to do at least:
    +        rm -rf standalone/dist/jdaviz.app/Contents/MacOS/jedi/third_party/typeshed/stdlib/
    +        rm -rf standalone/dist/jdaviz.app/Contents/MacOS/**/*.dist-info
    maartenbreddels committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    02e7025 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b0c526d View commit details
    Browse the repository at this point in the history
  4. GHA logic?

    maartenbreddels committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    afebeee View commit details
    Browse the repository at this point in the history
  5. code sign on gha

    maartenbreddels committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    309860a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    9577b2a View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c80aad5 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    3687266 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    6c5da95 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    a7c7e34 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    76657d1 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    8c0e2af View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    42cfcf2 View commit details
    Browse the repository at this point in the history
  14. fix syntax error

    maartenbreddels committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    e7cfa49 View commit details
    Browse the repository at this point in the history
  15. fix path

    maartenbreddels committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    f70642e View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    c083476 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    7c42fce View commit details
    Browse the repository at this point in the history
  18. fix: use ditto instead of zip

    from https://developer.apple.com/forums/thread/116831
    
    zip might cause issues with utf8 or metadata.
    maartenbreddels committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    dbd8142 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    4aa88bf View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    42d3eb1 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    00b1886 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2023

  1. Configuration menu
    Copy the full SHA
    3adfbb4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    18f750d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ab8f881 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    fc5fb85 View commit details
    Browse the repository at this point in the history
  5. BUG: Fix mouseover behavior in Cubeviz

    spectrum viewer when spatial subset is present.
    
    Co-authored-by: Duy Nguyen <duytnguyendtn.open@gmail.com>
    pllim and duytnguyendtn committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    df0ace8 View commit details
    Browse the repository at this point in the history
  6. Merge pull request spacetelescope#2258 from pllim/fix-cubeviz-spec-mo…

    …useover
    
    BUG: Fix mouseover behavior in Cubeviz
    pllim committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    6a79df3 View commit details
    Browse the repository at this point in the history
  7. Remove change log from spacetelescope#2258

    because the bug only affects unreleased code
    
    [ci skip] [rtd skip]
    pllim committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    54ae4c8 View commit details
    Browse the repository at this point in the history
  8. Deprecate get_subsets_from_viewer

    duytnguyendtn authored and pllim committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    8350d83 View commit details
    Browse the repository at this point in the history
  9. Missing region index

    duytnguyendtn authored and pllim committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    4872695 View commit details
    Browse the repository at this point in the history
  10. Fix subset args

    duytnguyendtn authored and pllim committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    83ccc6c View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    4c4ef73 View commit details
    Browse the repository at this point in the history
  12. Remove get_data_from_viewer from mosviz data loading test and sub har…

    …dcoded viewer ref names
    duytnguyendtn authored and pllim committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    30c5ec8 View commit details
    Browse the repository at this point in the history
  13. Mosviz test update image truth class

    duytnguyendtn authored and pllim committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    3638a50 View commit details
    Browse the repository at this point in the history
  14. Fix incorrect viewer ref

    duytnguyendtn authored and pllim committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    2b1eff9 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    4d6658d View commit details
    Browse the repository at this point in the history
  16. Non-existent data check

    duytnguyendtn authored and pllim committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    f43ee63 View commit details
    Browse the repository at this point in the history
  17. Properly deprecate getters

    duytnguyendtn authored and pllim committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    a402b02 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    e6b9eb4 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    723fe1a View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    4d6e2a4 View commit details
    Browse the repository at this point in the history
  21. Codestyle

    duytnguyendtn authored and pllim committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    ef6a38b View commit details
    Browse the repository at this point in the history
  22. Fix docs wording

    Co-authored-by: Jesse Averbukh <javerbukh@gmail.com>
    2 people authored and pllim committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    0817e83 View commit details
    Browse the repository at this point in the history
  23. Catch missed code, fix bug

    pllim committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    8672106 View commit details
    Browse the repository at this point in the history
  24. Retain Mosviz get_data behavior

    and fix change log
    pllim committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    1688ec1 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2023

  1. Undo bad diff

    pllim committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    06f2ed0 View commit details
    Browse the repository at this point in the history
  2. Merge pull request spacetelescope#2242 from duytnguyendtn/depsubsets

    Deprecate subset getters
    pllim committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    0fdb3bd View commit details
    Browse the repository at this point in the history
  3. MNT: Add .mailmap

    so git shortlog -es gives sane listing.
    pllim committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    a160c5f View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2023

  1. DOC: Add warning about surface brightness in Simple Aperture Photomet…

    …ry plugin (spacetelescope#2261)
    
    * DOC: Add warning about surface brightness
    in Simple Aperture Photometry plugin.
    
    I am beginning to think the Simple in plugin name no longer applies.
    
    * DOC: Improve verbiage.
    
    Co-authored-by: Camilla Pacifici <camilla.pacifici@gmail.com>
    
    ---------
    
    Co-authored-by: Camilla Pacifici <camilla.pacifici@gmail.com>
    pllim and camipacifici committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    d5fbd70 View commit details
    Browse the repository at this point in the history
  2. Merge pull request spacetelescope#2260 from pllim/add-git-mailmap

    MNT: Add .mailmap
    pllim committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    40116b9 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2023

  1. FEAT: Annulus draw tool for Imviz (spacetelescope#2240)

    * FEAT: Annulus draw tool for Imviz.
    
    TODO: Need to fix icon.
    
    TST: Add tests.
    
    [ci skip] [rtd skip]
    
    * Pull in spacetelescope#2204 into this PR
    and bump upstream pins
    
    * Changed function name
    upstream in glue-astronomy during review process
    
    * Proper annulus icon from J. Kotler
    
    Co-authored-by: Jennifer Kotler <jennlkotler@gmail.com>
    
    * Avoid error traceback with bad annulus radii
    
    * Disable recentering for annulus
    
    * Fix test failure
    because not sure why spectral region is using Imviz centering method
    but okay.
    
    ---------
    
    Co-authored-by: Jennifer Kotler <jennlkotler@gmail.com>
    Co-authored-by: Ricky O'Steen <rosteen@stsci.edu>
    3 people committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    bc6cdee View commit details
    Browse the repository at this point in the history
  2. MNT: Temporarily pin voila<0.5 (spacetelescope#2269)

    * MNT: Temp pin voila<0.5
    because voila-template is incompatible, see spacetelescope#2268
    
    * TST: Disable voila dev in test matrix
    pllim committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    55a19f4 View commit details
    Browse the repository at this point in the history
  3. TST: Ignore DeprecationWarning from asteval (spacetelescope#2274)

    * TST: Ignore DeprecationWarning from asteval.
    For example https://github.com/newville/asteval/issues/120
    
    * Also ignore FutureWarning from asteval
    pllim committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    a9f13e9 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2023

  1. Configuration menu
    Copy the full SHA
    4018883 View commit details
    Browse the repository at this point in the history
  2. Merge pull request spacetelescope#2278 from javerbukh/add-windows-kno…

    …wn-bug
    
    Add doc for windows latency issue
    pllim committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    b6feaa6 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2023

  1. Configuration menu
    Copy the full SHA
    2c03ef1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    eb62365 View commit details
    Browse the repository at this point in the history
  3. Docstring suggestions

    Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
    duytnguyendtn and pllim committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    91d6978 View commit details
    Browse the repository at this point in the history
  4. Changelog

    duytnguyendtn committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    40fd901 View commit details
    Browse the repository at this point in the history
  5. Changelog

    duytnguyendtn committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    a569123 View commit details
    Browse the repository at this point in the history
  6. Button to export Cubeviz movie (spacetelescope#2264)

    * WIP: Backend API to write movie file
    but got stuck with bqplot not cooperating after first frame.
    
    [ci skip] [rtd skip]
    
    * fix: bqplot stuck after the first frame of the movie
    
    We have to run the loop outside the main thread; otherwise, the
    processing of messages from the frontend is blocked, causing the
    message with the first image to never be received. The "save_image"
    method can only save the next image after the previous image is
    received.
    
    * Fix typo, this works now from the API.
    
    [ci skip] [rtd skip]
    
    * Add frontend and tests
    
    * Add user doc
    
    * DOC: Add note about standalone app
    saving file into weird places.
    
    * Address some review comments
    
    * Expose FPS and fix test
    
    * DOC: Baby Shark roundtrip
    as promised.
    
    * DOC: Ellie said more shark!
    
    * Vue.js style improvements
    
    [ci skip] [rtd skip]
    
    Co-authored-by: Kyle Conroy <kyleconroy@gmail.com>
    
    * Display pls install msg in plugin
    
    * Address review comments
    
    * Fix test
    
    * Fix path resolution in standalone app
    
    * Improve frontend validation and access.
    
    Co-authored-by: Kyle Conroy <kyleconroy@gmail.com>
    
    * Disable video for spectrum-viewer in GUI
    and add comment to Slice.
    
    * Add tooltip to kill switch
    but it only shows when activated
    
    * Rename kill with something less scary
    
    * Hide stop button
    since disabling is not obvious enough, also moar tooltip
    
    * Disable the whole movie menu for spectrum
    
    viewer in Cubeviz [ci skip] [rtd skip]
    
    Co-authored-by: Ricky O'Steen <39831871+rosteen@users.noreply.github.com>
    
    * Fix RTD warnings about invalid prop
    and remove unnecessary frontend check now that Ricky's suggestion is accepted.
    
    ---------
    
    Co-authored-by: Mario Buikhuizen <mariobuikhuizen@gmail.com>
    Co-authored-by: Kyle Conroy <kyleconroy@gmail.com>
    Co-authored-by: Ricky O'Steen <39831871+rosteen@users.noreply.github.com>
    4 people committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    24ff314 View commit details
    Browse the repository at this point in the history
  7. Merge pull request spacetelescope#2273 from duytnguyendtn/specload

    Replace load_spectrum with load_data
    duytnguyendtn committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    b365d80 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    d3d2513 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    cefb486 View commit details
    Browse the repository at this point in the history
  10. Codestyle

    duytnguyendtn committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    e652be8 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    f3bb66d View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    dff234b View commit details
    Browse the repository at this point in the history
  13. Codestyle

    duytnguyendtn committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    ceb79b0 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    b980750 View commit details
    Browse the repository at this point in the history
  15. Fix standalone bug

    duytnguyendtn committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    bfa8a41 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    73c4b6f View commit details
    Browse the repository at this point in the history
  17. Remove unused import

    Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
    duytnguyendtn and pllim committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    0df09d9 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    507a528 View commit details
    Browse the repository at this point in the history
  19. Changelog

    duytnguyendtn committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    47b50a5 View commit details
    Browse the repository at this point in the history
  20. Changelog

    Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
    duytnguyendtn and pllim committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    0cd7a80 View commit details
    Browse the repository at this point in the history
  21. Changelog

    duytnguyendtn committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    294c8d6 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    4c859b7 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2023

  1. Update .github/workflows/standalone.yml

    Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
    rosteen and pllim committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    42075d8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d421571 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9e2c857 View commit details
    Browse the repository at this point in the history
  4. Merge branch 'pyinstaller_v2' of https://github.com/maartenbreddels/j…

    …daviz into maarten-pyinstaller_v2
    rosteen committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    c28cb2e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    946780b View commit details
    Browse the repository at this point in the history