Debug standalone build #2349
Merged
Debug standalone build #2349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## debug-standalone-build #2349 +/- ##
=========================================================
Coverage ? 90.66%
=========================================================
Files ? 152
Lines ? 17422
Branches ? 0
=========================================================
Hits ? 15795
Misses ? 1627
Partials ? 0 ☔ View full report in Codecov by Sentry. |
rosteen
merged commit e21dd28
into
spacetelescope:debug-standalone-build
26 of 29 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying this again with (hopefully) secrets access for this PR so the build job will actually run and I can debug.
This build was passing in #1960, trying to figure out what changed. Note that I temporarily enabled the stand alone build for PRs so I can see test it here, this will be dropped before merge.