Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC: stretch-per-slice #2694

Closed
wants to merge 1 commit into from
Closed

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Feb 6, 2024

Description

This pull request implements a proof-of-concept for stretch-per-slice support using glue-viz/glue#2476.

Screen.Recording.2024-02-06.at.2.02.47.PM.mov

Future to-do items if we go in this direction:

  • consider moving plugin-level toggle to a viewer-level choice in plot options (placed alongside stretch options)
  • update stretch histogram to follow the same toggle (only show histogram of data in current slice when enabled)
  • handle manually setting vmin/vmax vs setting percentile.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added this to the 3.9 milestone Feb 6, 2024
@github-actions github-actions bot added cubeviz plugin Label for plugins common to multiple configurations labels Feb 6, 2024
@gibsongreen gibsongreen modified the milestones: 3.9, 3.10 Apr 5, 2024
@kecnry kecnry closed this Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cubeviz plugin Label for plugins common to multiple configurations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants