Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual regression testing / check if jdaviz application renders with jupyter lab 3.0 #543

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

maartenbreddels
Copy link
Collaborator

This is based on widgetti/ipyvolume#355 and bqplot/bqplot#1311

And is using:

It will start up jupyter lab, and use galata to execute the notebook, take a screenshot, and compare that to the screenshot in the repo.

@eteq expressed his concerns about the growth of the size of the repo if we have to push a lot of images.

@pllim
Copy link
Contributor

pllim commented Apr 20, 2021

app_ipynb_cell_0.png is a screenshot of some warning... is that intentional?

@maartenbreddels
Copy link
Collaborator Author

Good catch, I filtered the warning, since it includes the path (and thus will fail).

@maartenbreddels
Copy link
Collaborator Author

It seems we get some false positives due to some rendering 'artifacts' on the bottom of the jupyter lab interfaces:

Capture:
image

Reference:
image

I'll open an issue at Galata, and leave it for now until we decide we want to merge this/have it in CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants