Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JP-3625: Switch to IRAF starfinder default #8487

Merged
merged 5 commits into from
May 18, 2024
Merged

JP-3625: Switch to IRAF starfinder default #8487

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
13dfb7d
Switch to IRAF starfinder default
drlaw1558 May 15, 2024
df4b509
Add change log entry
drlaw1558 May 15, 2024
b437afa
Change default in docs
drlaw1558 May 15, 2024
f56a210
Change to iraf starfinder in tweakreg_catalog default
drlaw1558 May 17, 2024
2073da0
Merge branch 'master' into jp3625-starfinder
hbushouse May 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,9 @@ tweakreg

- Improve error handling in the absolute alignment. [#8450, #8477]

- Change code default to use IRAF StarFinder instead of
DAO StarFinder [#8487]

wfss_contam
-----------

Expand Down
2 changes: 1 addition & 1 deletion docs/jwst/tweakreg/README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ The ``tweakreg`` step has the following optional arguments:
in pixels. (Default=400)

* ``starfinder``: A `str` indicating the source detection algorithm to use.
Allowed values: `'iraf'`, `'dao'`, `'segmentation'`. (Default= `'dao'`)
Allowed values: `'iraf'`, `'dao'`, `'segmentation'`. (Default= `'iraf'`)

* ``snr_threshold``: A `float` value indicating SNR threshold above the
background. Required for all star finders. (Default=10.0)
Expand Down
2 changes: 1 addition & 1 deletion jwst/tweakreg/tweakreg_step.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ class TweakRegStep(Step):
use_custom_catalogs = boolean(default=False) # Use custom user-provided catalogs?
catalog_format = string(default='ecsv') # Catalog output file format
catfile = string(default='') # Name of the file with a list of custom user-provided catalogs
starfinder = option('dao', 'iraf', 'segmentation', default='dao') # Star finder to use.
starfinder = option('dao', 'iraf', 'segmentation', default='iraf') # Star finder to use.
snr_threshold = float(default=10.0) # SNR threshold above the bkg for star finder
# kwargs for DAOStarFinder and IRAFStarFinder, only used if starfinder is 'dao' or 'iraf'
kernel_fwhm = float(default=2.5) # Gaussian kernel FWHM in pixels
Expand Down
Loading