Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Do not write config on import #429

Merged
merged 1 commit into from
Apr 28, 2021

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Apr 9, 2021

This functionality will be deprecated in astropy in a future release. See astropy/astropy#11497 and https://groups.google.com/g/astropy-dev/c/KVzPgeihxO8

@codecov
Copy link

codecov bot commented Apr 9, 2021

Codecov Report

Merging #429 (fa5bae9) into develop (71f23fd) will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #429      +/-   ##
===========================================
+ Coverage    74.33%   74.41%   +0.07%     
===========================================
  Files           18       18              
  Lines         6161     6145      -16     
===========================================
- Hits          4580     4573       -7     
+ Misses        1581     1572       -9     
Impacted Files Coverage Δ
poppy/__init__.py 97.91% <ø> (+13.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71f23fd...fa5bae9. Read the comment docs.

@shanosborne shanosborne merged commit f52ac35 into spacetelescope:develop Apr 28, 2021
@pllim pllim deleted the config-no-write branch April 28, 2021 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants