Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add band to GainModel schema #219

Merged
merged 2 commits into from
Sep 25, 2023

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Sep 21, 2023

Miri gain files on CRDS now contain the BAND keyword.

This PR adds a reference to keyword_band.schema to gain.schema.

It is not clear to me if at this point the miri gain files should be handled by a more specific schema for the following reasons:

  • https://jira.stsci.edu/browse/CRDS-730 mentions a range of possible values, these are a subset but not a match of those defined inkeyword_band.schema (one example keyword_band.schema lists MEDIUM which is not listed in the ticket)
  • my cursory understanding is that gain.schema, used for GainModel, is used for all gain reference files on crds. There are gain files for: fgs, miri, nircam, niriss and nirspec. Not all of these use the BAND keyword and not all of these use the FILTER keyword. Although apparently not required by the schema this does mean that adding a ref to keyword_band.schema means the GainModel instances for all of these files will now have a model.meta.instrument.band attribute

Regression tests run with no errors: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/968/

Checklist

  • added entry in CHANGES.rst (either in Bug Fixes or Changes to API)
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch has no changes to coverable lines.

📢 Thoughts on this report? Let us know!.

Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hbushouse hbushouse merged commit 60d4223 into spacetelescope:master Sep 25, 2023
28 checks passed
@braingram braingram deleted the miri_gain_band branch September 25, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants