Updated deprecated uses of ASDF #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 1, 2023
braingram
force-pushed
the
asdf_extension
branch
from
eb0dd44
to
825332f
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #82 +/- ##
=========================================
Coverage ? 54.17%
=========================================
Files ? 25
Lines ? 3057
Branches ? 0
=========================================
Hits ? 1656
Misses ? 1401
Partials ? 0
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
braingram
force-pushed
the
asdf_extension
branch
from
b12a3d2
to
f1331e7
Compare
braingram
force-pushed
the
asdf_extension
branch
from
f1331e7
to
d7d787b
Compare
braingram
force-pushed
the
asdf_extension
branch
from
f5fde0f
to
676cd07
Compare
WilliamJamieson
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the legacy AsdfExtension defined in stpipe.integration with a new style resource_mapping.
AsdfExtension is deprecated and will produced DeprecationWarnings in ASDF 2.15 and errors in ASDF 3.0.
https://asdf.readthedocs.io/en/stable/asdf/extending/legacy.html
asdf-format/asdf#1429
While testing for style issues with flake8 an unrelated line was flagged (in tests/test_step.py). This minor change was included here to hopefully avoid any style check failures.