TST: Fix devdeps #183
Merged
TST: Fix devdeps #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and clean up tox/build settings
|
👋 Thank you for your draft pull request! Do you know that you can use |
|
Since we're building synphot from source in devdeps, might also need to pull in more stuff from spacetelescope/synphot_refactor#368 but let's wait and see first. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #183 +/- ##
=======================================
Coverage 84.66% 84.66%
=======================================
Files 13 13
Lines 1637 1637
=======================================
Hits 1386 1386
Misses 251 251 ☔ View full report in Codecov by Sentry. |
|
Interestingly enough, simple patch is fine here. 🤷 The linkcheck failure is unrelated. I have contacted NMSU to ask why APO website is down. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the failing devdeps job.
xref astropy/astropy#15638