Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Fix devdeps #368

Merged
merged 8 commits into from Nov 21, 2023
Merged

TST: Fix devdeps #368

merged 8 commits into from Nov 21, 2023

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Nov 21, 2023

Description

This pull request is to fix devdeps job failure.

xref astropy/astropy#15638

@pllim pllim added the testing label Nov 21, 2023
@pllim pllim added this to the 1.3.0 milestone Nov 21, 2023
Copy link

Thank you for your contribution! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the STScI coding guidelines?
  • Are tests added/updated as required? If so, do they follow the STScI testing guidelines?
  • Are docs added/updated as required?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions.
  • Did the CI pass? If no, are the failures related?
  • Is a change log needed?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.

Copy link

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7eaa3dc) 96.80% compared to head (d9a9a03) 96.80%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #368   +/-   ##
=======================================
  Coverage   96.80%   96.80%           
=======================================
  Files          17       17           
  Lines        2034     2034           
=======================================
  Hits         1969     1969           
  Misses         65       65           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pllim
Copy link
Contributor Author

pllim commented Nov 21, 2023

Tsk tsk, need to build C-extension with unreleased numpy.

@pllim pllim marked this pull request as ready for review November 21, 2023 20:53
@pllim
Copy link
Contributor Author

pllim commented Nov 21, 2023

The devdeps log still makes no sense to me but somehow the failure went away. I'll call this a win and move on.

.pkg: freeze> python -m pip freeze --all
.pkg: numpy==1.26.2,packaging==23.2,pip==23.3.1,setuptools==69.0.2,setuptools-scm==8.0.4,typing_extensions==4.8.0,wheel==0.41.3

@pllim pllim merged commit 4a5f8a6 into spacetelescope:master Nov 21, 2023
21 checks passed
@pllim pllim deleted the fix-devdeps branch November 21, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant