Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: ptp was removed from the ndarray class in NumPy 2.0 #366

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Sep 25, 2023

Description

This pull request is to keep up with continuous numpy 2.0.dev changes upstream. Something new every day.

@pllim pllim added this to the 1.3.0 milestone Sep 25, 2023
@github-actions
Copy link

Thank you for your contribution! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the STScI coding guidelines?
  • Are tests added/updated as required? If so, do they follow the STScI testing guidelines?
  • Are docs added/updated as required?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions.
  • Did the CI pass? If no, are the failures related?
  • Is a change log needed?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.

@github-actions
Copy link

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
synphot/filter_parameterization/filter_fft.py 98.27% <100.00%> (ø)

📢 Thoughts on this report? Let us know!.

@pllim pllim marked this pull request as ready for review September 25, 2023 18:45
@pllim pllim merged commit cfd5cd8 into spacetelescope:master Sep 25, 2023
22 checks passed
@pllim pllim deleted the np2-ptp branch September 25, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant