Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for saving GriddedPSFModel into FITS file #284

Merged
merged 1 commit into from
Mar 14, 2019

Conversation

shanosborne
Copy link
Contributor

There was an issue with setting the WFE information in the FITS header. To fix this, you can just pull that information from the header of the individual PSF so it's already properly formatted, rather than re-format it here as well.

Fixes #282

@mperrin mperrin self-requested a review March 14, 2019 20:16
Copy link
Collaborator

@mperrin mperrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! :-)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 135

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 40.758%

Totals Coverage Status
Change from base Build 133: 0.0%
Covered Lines: 2033
Relevant Lines: 4988

💛 - Coveralls

@mperrin mperrin merged commit 30bff43 into spacetelescope:master Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error saving GriddedPSFModel into fits file
3 participants