-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create entry point for starfish/experiment/builder/cli.py #436
Conversation
2222d14
to
c4444c0
Compare
Codecov Report
@@ Coverage Diff @@
## master #436 +/- ##
==========================================
+ Coverage 84.73% 85.39% +0.65%
==========================================
Files 72 72
Lines 2765 2773 +8
==========================================
+ Hits 2343 2368 +25
+ Misses 422 405 -17
Continue to review full report at Codecov.
|
setup.py
Outdated
'console_scripts': "starfish=starfish.starfish:starfish" | ||
'console_scripts': [ | ||
"starfish=starfish.starfish:starfish", | ||
"build_sample_experiment=starfish.experiment.builder.cli:main", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think b_s_e would surprise me if it showed up on $PATH
after pip install starfish
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, I had similar thoughts. I think it might make more sense to include it as a sub-module of starfish. For now, tagging it with a name that associates with our package is enough for me because I want to get this out to collaborators.
Suggestion:
build_sample_starfish_experiment
+ new issue to include it in the starfish binary.
c4444c0
to
ebe5ebd
Compare
Made this a subcommand of the starfish cli. Example invocation: |
41c6be9
to
db9f6f1
Compare
Lol, love that as a side effect of this change, it also displays the starfish ascii art. |
13e577b
to
ddcbfd1
Compare
ddcbfd1
to
6d59a64
Compare
The most important change. That the tool is wired up is the side effect. :) |
1. Create a "main" method for the script. 2. Add an entry point for the pip package. Test plan: ``` % pip install -e . % build_sample_experiment --help ```
6d59a64
to
7231ed1
Compare
LOL
…On Fri, Aug 17, 2018 at 1:12 PM Tony Tung ***@***.***> wrote:
Lol, love that as a side effect of this change, it also displays the
starfish ascii art.
The most important change. That the tool is wired up is the side effect. :)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#436 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AClETAGF6wj0mfQC65JwIqiUPa9O2GpCks5uRyPLgaJpZM4V_WkH>
.
|
Test plan:
Connects to #418