-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conda docker #495
Merged
Merged
Conda docker #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the other .travis.yml builds test the REQUIREMENTS* files, this now tests an environment.yml in docker. There's an outstanding issue with slicedimage and its enum34 dep which will need to be fixed before this is mergeable.
joshmoore
force-pushed
the
conda-docker
branch
from
August 31, 2018 11:44
bcd517f
to
f2d24e9
Compare
joshmoore
force-pushed
the
conda-docker
branch
from
August 31, 2018 11:48
f2d24e9
to
68da444
Compare
Codecov Report
@@ Coverage Diff @@
## master #495 +/- ##
=======================================
Coverage 82.77% 82.77%
=======================================
Files 87 87
Lines 3245 3245
=======================================
Hits 2686 2686
Misses 559 559 Continue to review full report at Codecov.
|
ttung
approved these changes
Sep 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the other .travis.yml builds test the REQUIREMENTS*
files, this now tests an environment.yml in docker. There's
an outstanding issue with slicedimage and its enum34 dep
which will need to be fixed before this is mergeable.
see #44
close #511
(Was previously opened as #472)