Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuke a bunch of references to hyb. #702

Merged
merged 1 commit into from
Oct 17, 2018
Merged

Nuke a bunch of references to hyb. #702

merged 1 commit into from
Oct 17, 2018

Conversation

ttung
Copy link
Collaborator

@ttung ttung commented Oct 11, 2018

hyb, as a dimension, should be round/r.

Note that I did not change 'hybridization', which is a reference to the primary image(s), pending the discussion of singular vs plural. :)

Test plan: make -j fast run_notebooks

@codecov-io
Copy link

codecov-io commented Oct 11, 2018

Codecov Report

Merging #702 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #702   +/-   ##
=======================================
  Coverage   85.83%   85.83%           
=======================================
  Files         123      123           
  Lines        4285     4285           
=======================================
  Hits         3678     3678           
  Misses        607      607
Impacted Files Coverage Δ
starfish/test/dataset_fixtures.py 52.33% <ø> (ø) ⬆️
...tarfish/test/spots/detector/test_spot_detection.py 100% <ø> (ø) ⬆️
starfish/spots/_detector/detect.py 96.61% <ø> (ø) ⬆️
starfish/experiment/builder/defaultproviders.py 95.12% <100%> (ø) ⬆️
starfish/test/image/test_imagestack_metadata.py 97.29% <100%> (ø) ⬆️
starfish/experiment/builder/providers.py 79.16% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1af43c9...65be2dd. Read the comment docs.

@ttung ttung force-pushed the tonytung-hyb branch 5 times, most recently from 12be640 to a5f84d6 Compare October 17, 2018 01:40
hyb, as a dimension, should be round/r.

Note that I did not change 'hybridization', which is a reference to the primary image(s), pending the discussion of singular vs plural. :)

Test plan: `make -j fast run_notebooks`
@ttung ttung merged commit 87d4638 into master Oct 17, 2018
@ttung ttung deleted the tonytung-hyb branch October 17, 2018 04:55
@ttung ttung restored the tonytung-hyb branch October 17, 2018 04:58
@ttung ttung deleted the tonytung-hyb branch October 25, 2018 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants