Fix E605 warnings. #780
Merged
Fix E605 warnings. #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Codecov Report
@@ Coverage Diff @@
## master #780 +/- ##
======================================
Coverage 87.3% 87.3%
======================================
Files 148 148
Lines 4885 4885
======================================
Hits 4265 4265
Misses 620 620
Continue to review full report at Codecov.
|
ttung
force-pushed
the
tonytung-e605
branch
5 times, most recently
from
9ab03a4
to
d1bb526
Compare
ttung
force-pushed
the
tonytung-e605
branch
5 times, most recently
from
4452112
to
80b5555
Compare
ttung
force-pushed
the
tonytung-e605
branch
6 times, most recently
from
9b96326
to
237e534
Compare
1. Put back E605 as a valid warning. 2. Use r-style strings to not quote backslashes.
|
this is so ez i'm going to land this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plan:
make -j lint, waiting on travis now...