Add option to softwarechannel_setorgaccess for protected sharing of channels #311
Conversation
channels. Use -p ORG one or more times to share the channel only with ORG. Added also two new commands to work with base channel and it's child channels at once: softwarechannel_setorgaccesstree softwarechannel_getorgaccesstree
|
Hello, I marked 2 lines, build failed because of them. Please look at them. What's the point of "I dont know what i am doing." commit? :-) |
corrected copy/paste error, it has to be self.help_softwarechannel_setorgaccesstree() within do_softwarechannel_setorgaccesstree.
|
@jdobes in line 1605 I used do_softwarechannel_setorgaccess as template, there we have also two times "if not len(args)": |
|
@jdobes the "I dont know what i am doing." commit was because git did not allow me to do "git rebase upstream/master" because of unstaged changes in rel-eng/packages/.readme. I did not touch this file and a "git checkout -- rel-eng/packages/.readme" did also not revert the changes. |
|
@jdobes, if you'd accept the PR, please add the bug number 1277994 to the commit messages. Thank you. |
|
It does what it says, merging as one commit - 95dd667 . Thanks. |
Working with multiple organisations which do not share all channels with each other it is convenient to extend the softwarechannel_[s|g]etorgaccess commands:
I added the option --protected to enable channel sharing only for the given organisations to software_channelsetorgaccess.
software_channelgetorgaccess now reports for protected channels for all trusted organisations if they are enabled or disabled.
And I added software_channel[s|g]etorgaccesstree to work with whole channel trees. Most of the time you want to have the same sharing options on the whole channel tree of a base channel.
I could not figure out why rel-eng/packages/.readme was changed...