Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packaging Tutorial: minor updates #347

Merged
merged 5 commits into from
May 12, 2024

Conversation

adamjstewart
Copy link
Member

Minor grammar stuff and line numbers.

I noticed that the example from spack create does not contain a line for the new license(...) directive. Are we not auto-generating those files?

Tomorrow once the docker images are available, I'm going to walk through the entire tutorial one more time myself and add the license stuff.

@adamjstewart adamjstewart marked this pull request as draft May 11, 2024 19:06
@adamjstewart
Copy link
Member Author

@tldahlgren just a heads up, I removed many of the emphasize-lines from this tutorial. Specifically, I removed them from all auto-generated output that frequently changes and only kept them for package.py files which we control and configure --help output which will never change. This will make it easier to maintain this in the future. But feel free to add some of these back next time you present this section.

@adamjstewart adamjstewart marked this pull request as ready for review May 12, 2024 13:14
@becker33 becker33 merged commit dd75cee into spack:main May 12, 2024
2 checks passed
@adamjstewart adamjstewart deleted the tutorials/packaging branch May 12, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants