Skip to content

Commit

Permalink
Perl package: change attr to method (#36580)
Browse files Browse the repository at this point in the history
This fixes a bug in the Windows build of Perl.

An attribute defined in package class is inaccessible from the install
method due to builder: refactor it to be a method.
  • Loading branch information
johnwparent committed Apr 1, 2023
1 parent 1175831 commit d79c817
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions var/spack/repos/builtin/packages/perl/package.py
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,6 @@ def do_stage(self, mirror_only=False):
perm = os.stat(filename).st_mode
os.chmod(filename, perm | 0o200)

@property
def nmake_arguments(self):
args = []
if self.spec.satisfies("%msvc"):
Expand Down Expand Up @@ -304,7 +303,7 @@ def install(self, spec, prefix):
if sys.platform == "win32":
win32_dir = os.path.join(self.stage.source_path, "win32")
with working_dir(win32_dir):
nmake("install", *self.nmake_arguments, ignore_quotes=True)
nmake("install", *self.nmake_arguments(), ignore_quotes=True)
else:
make("install")

Expand Down

0 comments on commit d79c817

Please sign in to comment.