tests: test_stage fails when run with -k

[tldahlgren]

It appears the test_stage test fails when run tests filtered on stage.

Steps to reproduce the issue

$ spack test -k stage
$ spack test -k test_stage

Error Message

The test checks to ensure the mock_stage directory was used and fails. In the first case, the first defaultconfig:build_stage directory is used for staging. In the second case, the first path in the config:build_stage directory of test/data/config.yaml is used.

spec = mpileaks@2.3%gcc@4.5.0~debug~opt+shared+static arch=test-debian6-x86_64 ^callp... arch=test-debian6-x86_64 ^mpich@3.0.4%gcc@4.5.0~debug arch=test-debian6-x86_64

    def check_stage(spec):
        spec = Spec(spec).concretized()
        for dep in spec.traverse():
            stage_name = "%s-%s-%s" % (dep.name, dep.version, dep.dag_hash())
>           assert os.path.isdir(os.path.join(root, stage_name))
E           AssertionError: assert False
E            +  where False = <function isdir at 0x2aaaaab64050>('/tmp/yser/pytest-of-user/pytest-0/mock-stage0/mpileaks-2.3-b4ervofanrurvlocnwdcezqekdphknd6')
E            +    where <function isdir at 0x2aaaaab64050> = <module 'posixpath' from '/usr/tce/packages/python/python-2.7.16/lib/python2.7/posixpath.pyc'>.isdir
E            +      where <module 'posixpath' from '/usr/tce/packages/python/python-2.7.16/lib/python2.7/posixpath.pyc'> = os.path
E            +    and   '/tmp/user/pytest-of-user/pytest-0/mock-stage0/mpileaks-2.3-b4ervofanrurvlocnwdcezqekdphknd6' = <function join at 0x2aaaaab64f50>('/tmp/user/pytest-of-user/pytest-0/mock-stage0', 'mpileaks-2.3-b4ervofanrurvlocnwdcezqekdphknd6')
E            +      where <function join at 0x2aaaaab64f50> = <module 'posixpath' from '/usr/tce/packages/python/python-2.7.16/lib/python2.7/posixpath.pyc'>.join
E            +        where <module 'posixpath' from '/usr/tce/packages/python/python-2.7.16/lib/python2.7/posixpath.pyc'> = os.path

Information on your system

Linux ... SMP Tue May 14 18:38:00 PDT 2019 x86_64 x86_64 x86_64 GNU/Linux

[alalazo]

Ouch, that means very likely that we have tests that depend on the state left by previous tests to pass 😢 As soon as we have time it could be good to run tests locally with this plugin to find which other tests are showing the same issue.