"spack test" wrongly adds directory to config.yaml

[greenc-FNAL]

Using the current HEAD of develop (5a6d060), it appears that packages are being staged in an apparently inappropriate place:

[greenc@cluck] ~/work/cet-is/sources/spack-test (develop) $ spack -d stage cmake
<snip>
==> [2019-09-12-10:15:39.843513] Using cached archive: /scratch/greenc/spack-tree-02/source-cache/cmake/cmake-3.15.1.tar.gz
==> [2019-09-12-10:15:39.938362] Staging archive: /tmp/pytest-of-greenc/pytest-8/mock-stage0/cmake-3.15.1-avrtc33dfzhnl2bz4qc2prld7a2fb4iz/cmake-3.15.1.tar.gz
==> [2019-09-12-10:15:39.940518] '/usr/bin/tar' '-xf' '/tmp/pytest-of-greenc/pytest-8/mock-stage0/cmake-3.15.1-avrtc33dfzhnl2bz4qc2prld7a2fb4iz/cmake-3.15.1.tar.gz'
==> [2019-09-12-10:15:40.807888] Created stage in /tmp/pytest-of-greenc/pytest-8/mock-stage0/cmake-3.15.1-avrtc33dfzhnl2bz4qc2prld7a2fb4iz

The relevant section of my config.yaml says:

  build_stage:
    - /scratch/$user/spack-tree-02/build-stage
    - $tempdir

Is this some hysteresis / cache pollution caused by prior use of spack test, or something else? @tldahlgren?

Thanks,
Chris.

[greenc-FNAL]

spack clean -s doesn't appear to clear an already-downloaded tarball either.

[scheibelp]

Does spack config blame config show a test directory in your build_stage entries? I think if you have run spack test this may be happening unintentionally

[greenc-FNAL]

Indeed, this was inserted in ~/.spack/config.yaml, apparently:

[greenc@cluck] ~/work/cet-is/sources/spack-test (develop) $ spack config blame config | grep stage
/home/greenc/.spack/config.yaml:2                                                 build_stage: /tmp/pytest-of-greenc/pytest-8/mock-stage0

I can remove it manually, of course, but I would expect that this is something we would wish to avoid happening in the first place?

[scheibelp]

this is something we would wish to avoid happening in the first place?

Yes, we want to fix this - thanks for reporting it!

[greenc-FNAL]

I would also suggest that the config change for testing made in the installation-specific config.yaml rather than the user level in order to prevent cross-contamination of multiple Spack installations.

[tldahlgren]

IIRC There was some offline discussion on this and someone proposed using a custom scope for testing.