spack-python does not exit failure on exceptions

[Jordan474]

Steps to reproduce

Spack-python could be powerful tool to easily write scripts, but it ignores exceptions, which makes writing reliable scripts impossible.

For example:

$ cat myscript
#!/usr/bin/env spack-python
import badimport

$ chmod +x myscript

$ source share/spack/setup-env.sh
$ ./myscript; echo $?
Traceback (most recent call last):
  File "/usr/lib/python3.10/code.py", line 90, in runcode
    exec(code, self.locals)
  File "./myscript", line 2, in <module>
    import badimport
ModuleNotFoundError: No module named 'badimport'
0

Its exit status is 0 instead of non-zero.

It seems spack-python actually runs an interactive console, I'm not sure this is appropriate for this use-case (described in bin/spack-python file) ?

Error message

Spack-python should exit with a non-zero status on errors.

Information on your system

• Spack: 0.20.0.dev0 (f5fd7e5109b24bfb5e5e5321091d083fa32cae17)
• Python: 3.10.6
• Platform: linux-ubuntu22.04-skylake
• Concretizer: clingo

General information

• I have run spack debug report and reported the version of Spack/Python/Platform
• I have searched the issues of this repo and believe this is not a duplicate
• I have run the failing commands in debug mode and reported the output