Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate exceptions from Spack python console #34547

Merged

Conversation

alalazo
Copy link
Member

@alalazo alalazo commented Dec 15, 2022

fixes #34489

Customize sys.excepthook to raise SystemExit when any unhandled exception reaches the hook.

fixes spack#34489

Customize sys.excepthook to raise SystemExit when
any unhandled exception reaches the hook.
@alalazo alalazo added the bugfix Something wasn't working, here's a fix label Dec 15, 2022
@alalazo alalazo added this to the v0.19.1 milestone Dec 15, 2022
@spackbot-app spackbot-app bot added commands core PR affects Spack core functionality labels Dec 15, 2022
@alalazo
Copy link
Member Author

alalazo commented Dec 15, 2022

@Jordan474 Can you check this works as expected for you?

@alalazo alalazo merged commit 22922bf into spack:develop Dec 15, 2022
@alalazo alalazo deleted the bugfix/propagate_exceptions_from_repl branch December 15, 2022 17:08
@alalazo alalazo mentioned this pull request Dec 15, 2022
20 tasks
@Jordan474
Copy link
Contributor

This works as expected; Thank You.

benkirk pushed a commit to benkirk/spack that referenced this pull request Dec 16, 2022
fixes spack#34489

Customize sys.excepthook to raise SystemExit when
any unhandled exception reaches the hook.
haampie pushed a commit that referenced this pull request Dec 22, 2022
fixes #34489

Customize sys.excepthook to raise SystemExit when
any unhandled exception reaches the hook.
haampie pushed a commit that referenced this pull request Dec 23, 2022
fixes #34489

Customize sys.excepthook to raise SystemExit when
any unhandled exception reaches the hook.
haampie pushed a commit that referenced this pull request Jan 18, 2023
fixes #34489

Customize sys.excepthook to raise SystemExit when
any unhandled exception reaches the hook.
haampie pushed a commit that referenced this pull request Jan 24, 2023
fixes #34489

Customize sys.excepthook to raise SystemExit when
any unhandled exception reaches the hook.
haampie pushed a commit that referenced this pull request Feb 7, 2023
fixes #34489

Customize sys.excepthook to raise SystemExit when
any unhandled exception reaches the hook.
alalazo added a commit that referenced this pull request Feb 7, 2023
fixes #34489

Customize sys.excepthook to raise SystemExit when
any unhandled exception reaches the hook.
amd-toolchain-support pushed a commit to amd-toolchain-support/spack that referenced this pull request Feb 16, 2023
fixes spack#34489

Customize sys.excepthook to raise SystemExit when
any unhandled exception reaches the hook.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Something wasn't working, here's a fix commands core PR affects Spack core functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spack-python does not exit failure on exceptions
3 participants