Add an ACTS package #10600
Add an ACTS package #10600
Conversation
HadrienG2
force-pushed
the
acts-package
branch
4 times, most recently
from
b5c26de
to
ae61261
Compare
HadrienG2
force-pushed
the
acts-package
branch
from
17ff1ed
to
bed35a5
Compare
There was a problem hiding this comment.
Hi @HadrienG2
Nice PR, I had already an ad-hoc recipe for the FCC software on a different so I put some questions below.
Also, in my recipe I had only support for versions 0.5.3 and 0.07.01, which I think add a couple of if-else statements to the recipe since there were significant changes between those versions and 0.8:, however those can be considered on a later PR (the current recipe we use in FCC is here)
|
|
||
| depends_on('cmake @3.7:', type='build') | ||
| depends_on('boost @1.62: +program_options +test') | ||
| depends_on('eigen @3.2.9:', type='build') |
There was a problem hiding this comment.
Have you seen problems finding eigen ? I had to add this to the cmake_args:
args.extend(["-DEIGEN_INCLUDE_DIR=%s" % spec['eigen'].prefix + "/include/eigen3"])
There was a problem hiding this comment.
CMake's Eigen include path detection is... finnicky to say the least. I needed similar things for my manual builds, but strangely enough things Just Work out of the box when building using spack. I suspect that Spack must set some CPATH environment somewhere to make this work.
There was a problem hiding this comment.
@HadrienG2 FYI, Spack doesn't set CPATH but injects include paths into the command line. See e.g. #10623 and the other PRs referred therein.
|
Regarding choice of versions, I usually tend to only include the latest release(s) of a package in my PRs for new spack packages, because older releases tend to need more build hacks and most HEP experiments tend to stay very close to the current package versions, making old releases rarely needed. Now, if you tell me that you are still using some of the older releases and have a good reason to stick with them, I don't mind adding support for them of course 😉 |
This is a build recipe for the ACTS HEP tracking toolkit.