Compiler wrappers don't add "pkg.headers.directories" to the include list #10604
Conversation
fixes spack#10601 Due to a bug this attribute is wrong for packages that use directories as namespaces. For instance it will add "<boost-prefix>/include/boost" instead of "<boost-prefix>/include" to the include path. As a minor addition a few loops in the compiler wrappers have been simplified.
|
@davydden With this I'm able again to build $ spack install -j 2 cmake
[...]
==> Successfully installed cmake
Fetch: 0.05s. Build: 8m 43.00s. Total: 8m 43.05s.
[+] /home/mculpo/PycharmProjects/spack/opt/spack/linux-ubuntu18.04-x86_64/gcc-8.2.0/cmake-3.13.4-fehljuzg2ydcsq2tyq2jonztuxds2usncan you double check if it solves also your issue? Also pinging @jabl and @HadrienG2 as their build errors might be related to this. |
perhaps we can make |
@davydden I think this needs to be addressed in a cleaner way as it involves quite a few packages. I vaguely remember there was an issue open for that, but can't find it anymore. In the worst case I'll open a new one soon. |
fair enough. |
There was a problem hiding this comment.
I'm going to merge this as a hotfix for now, but @scheibelp should investigate how to reconcile it with #8136.
|
@tgamblin Time permitting, I'll have a look tomorrow at |
This restores the use of Package.headers when computing -I options for building a package that was added in #8136 and reverted in #10604. #8136 used utility logic that located all header files in an installation prefix, and calculated the -I options as the immediate roots containing those header files. In some cases, for a package containing a directory structure like prefix/ include/ ex1.h subdir/ ex2.h dependents may expect to include ex2.h relative to 'include', and adding 'prefix/include/subdir' as a -I was causing errors, in particular if ex2.h has the same name as a system header. This updates header utility logic to by default return the base "include" directory when it exists, rather than subdirectories. It also makes it possible for package implementers to override Package.headers to return the subdirectory when it is required (for example with libxml2).
fixes #10601
fixes #10603
Due to a bug this attribute is wrong for packages that use directories as namespaces. For instance it will add
<boost-prefix>/include/boostinstead of<boost-prefix>/includeto the include path.As a minor addition a few loops in the compiler wrappers have been simplified.