Fix Spack Environments bug with space in PATH #12759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping |
|
Thanks! |
tldahlgren
pushed a commit
to tldahlgren/spack
that referenced
this pull request
Oct 11, 2019
This updates logic which sets shell variables to quote the values, which is necessary when the value contains a space (e.g. PATH).
jrmadsen
pushed a commit
to jrmadsen/spack
that referenced
this pull request
Oct 30, 2019
This updates logic which sets shell variables to quote the values, which is necessary when the value contains a space (e.g. PATH).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12730
Not sure what other bugs this may have influenced, or if there are other places in Spack where we should be escaping spaces in paths and we're not currently.
@tgamblin @alalazo