Buildcache: Catch warning from visit(root) in full_hash() call tree to allow completion of .spack file when using relative rpath option. #13265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gartung
changed the title
…all does not catch it and bail on creating the yaml file needed to create the .spack file.
gartung
force-pushed
the
gartung-buildcache-relative-rpath-fix
branch
from
0a9ea46
to
e428213
Compare
|
@tgamblin Can I merge this? |
|
Looking forward to this making it in! I will immediately be able to use this to cache some important + large packages. |
|
@tgamblin can this be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A warning prevents the completion of building a .spack file when the relative rpaths option is used.
See #13237 for details
The warning comes during this call
spack/lib/spack/spack/util/package_hash.py
Line 126 in b438382
My solution is to put a try except statement around it the catch the warning so it does not propagate higher and prevent the yaml file needed for the .spack file from being created.