Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Bugfix: add package AST check to ensure full hash works #13620

Closed
wants to merge 5 commits into from

Conversation

scheibelp
Copy link
Member

@scheibelp scheibelp commented Nov 6, 2019

(UPDATE 12/12: I'm working on an alternative to this: see #13620 (comment))

Closes #13265
Fixes #13237

Some valid python syntax in package.py files does not work with full hashes (these hashes include the DAG details as well as a hash of the package contents, and are used for creating buildcache tarballs). This adjusts the one package which was using logic that did not work, and also adds a spack package-ast-check command that is called as part of the CI to make sure that future edits to packages work with Spec.full_hash

@tgamblin tgamblin self-requested a review December 11, 2019 19:42
@scheibelp
Copy link
Member Author

UPDATE 12/12: I'm working on an alternative that will allow the swig package.py to remain unchanged; the new approach will default to including any AST content if it cannot determine whether to filter it out (as occurs for swig).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

buildcache create ends without finishing, gives Warning: 'Name' object has no attribute 's'
1 participant