[WIP] Bugfix: add package AST check to ensure full hash works #13620
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(UPDATE 12/12: I'm working on an alternative to this: see #13620 (comment))
Closes #13265
Fixes #13237
Some valid python syntax in package.py files does not work with full hashes (these hashes include the DAG details as well as a hash of the package contents, and are used for creating buildcache tarballs). This adjusts the one package which was using logic that did not work, and also adds a
spack package-ast-check
command that is called as part of the CI to make sure that future edits to packages work withSpec.full_hash