Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: installer.py shouldn't be executable #15386

Merged
merged 1 commit into from
Mar 8, 2020

Conversation

tgamblin
Copy link
Member

@tgamblin tgamblin commented Mar 7, 2020

This is a minor permission fix on the new installer.py introduced in #13100.

@tgamblin tgamblin added the bugfix Something wasn't working, here's a fix label Mar 7, 2020
@tgamblin tgamblin requested a review from tldahlgren March 7, 2020 21:23
@tgamblin tgamblin changed the title bugfix: installer.py was marked executable but shouldn't be bugfix: installer.py shouldn't be executable Mar 7, 2020
This is a minor permission fix on the new installer.py introduced in #13100.
@tgamblin tgamblin force-pushed the fix-permissions-on-installer branch from 920fd9b to e006c3e Compare March 7, 2020 21:25
@tgamblin tgamblin added this to In progress in Spack v0.14.1 release via automation Mar 7, 2020
Spack v0.14.1 release automation moved this from In progress to Reviewer approved Mar 7, 2020
@tgamblin tgamblin merged commit 49ec260 into develop Mar 8, 2020
Spack v0.14.1 release automation moved this from Reviewer approved to Done Mar 8, 2020
@alalazo alalazo deleted the fix-permissions-on-installer branch March 8, 2020 08:55
@tgamblin tgamblin moved this from Done to Reviewer approved in Spack v0.14.1 release Mar 19, 2020
@tgamblin tgamblin moved this from Reviewer approved to Done in Spack v0.14.1 release Mar 20, 2020
tgamblin added a commit that referenced this pull request Mar 20, 2020
This is a minor permission fix on the new installer.py introduced in #13100.
likask pushed a commit to likask/spack that referenced this pull request Apr 7, 2020
…upstream_master

* commit 'e2b1737a42c9c0c796671f9dd0c39f623e4c91c0': (1343 commits)
  update CHANGELOG.md for 0.14.1
  version bump: 0.14.1
  multiprocessing: allow Spack to run uninterrupted in background (spack#14682)
  Cray bugfix: TERM missing while reading default target (spack#15381)
  Upstreams: don't write metadata directory to upstream DB (spack#15526)
  Creating versions from urls doesn't modify class attributes (spack#15452)
  bugfix: fix install_missing_compilers option bug from v0.14.0 (spack#15416)
  bugfix: installer.py shouldn't be executable (spack#15386)
  Add function replace_prefix_nullterm for use on mach-o rpaths. (spack#15347)
  ArchSpec: fix semantics of satisfies when not concrete and strict is true (spack#15319)
  suite-sparse: fix installation for v5.X (spack#15326)
  testing:  increase installer coverage (spack#15237)
  bugfix: resolve undefined source_pkg_dir failure (spack#15339)
  Bugfix: resolve StopIteration message attribute failure (spack#15341)
  Recover coverage from subprocesses during unit tests (spack#15354)
  Correct pytest.raises matches to match (spack#15346)
  bugfix:  Add dependents when initializing spec from yaml (spack#15220)
  Uniquify suffixes added to module names (spack#14920)
  bugfix: ensure proper dependency handling for package-only installs (spack#15197)
  Fix for being able to 'spack load' packages that have been renamed. (spack#14348)
  ...

# Conflicts:
#	.travis.yml
#	lib/spack/spack/modules/common.py
#	var/spack/repos/builtin/packages/mofem-cephas/package.py
#	var/spack/repos/builtin/packages/mofem-fracture-module/package.py
#	var/spack/repos/builtin/packages/mofem-users-modules/package.py
#	var/spack/repos/builtin/packages/python/package.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Something wasn't working, here's a fix
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants