Creating versions from urls doesn't modify class attributes #15452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Errors in CI are before running tests: I'll try to restart them later. |
|
@mwkrentel With this PR and a locally modified version of $ spack info bzip2
Package: bzip2
Description:
bzip2 is a freely available, patent free high-quality data compressor.
It typically compresses files to within 10% to 15% of the best available
techniques (the PPM family of statistical compressors), whilst being
around twice as fast at compression and six times faster at
decompression.
Homepage: https://sourceware.org/bzip2/
Tags:
None
Preferred version:
1.0.8 htt://sourceware.org/pub/bzip2/bzip2-1.0.8.tar.gz
Safe versions:
1.0.8 htt://sourceware.org/pub/bzip2/bzip2-1.0.8.tar.gz
1.0.7 htt://sourceware.org/pub/bzip2/bzip2-1.0.7.tar.gz
1.0.6 htt://sourceware.org/pub/bzip2/bzip2-1.0.6.tar.gz
Variants:
Name [Default] Allowed values Description
============== ============== ==============================
shared [on] True, False Enables the build of shared
libraries.
Installation Phases:
install
Build Dependencies:
diffutils
Link Dependencies:
None
Run Dependencies:
None
Virtual Packages:
NoneThe broken |
|
Yes, Thanks! |
fixes spack#15449 Before this PR a call to pkg.url_for_version was modifying class attributes determining different results for subsequents calls and an error when the urls was empty.
alalazo
force-pushed
the
fixes/spack_info_and_urls
branch
from
4057c60
to
abdb3ee
Compare
|
@tgamblin @becker33 @scheibelp Also merging this 3 lines bugfix to solve an issue reported yesterday |
tgamblin
pushed a commit
that referenced
this pull request
Mar 20, 2020
fixes #15449 Before this PR a call to pkg.url_for_version was modifying class attributes determining different results for subsequents calls and an error when the urls was empty.
likask
pushed a commit
to likask/spack
that referenced
this pull request
Apr 7, 2020
…upstream_master * commit 'e2b1737a42c9c0c796671f9dd0c39f623e4c91c0': (1343 commits) update CHANGELOG.md for 0.14.1 version bump: 0.14.1 multiprocessing: allow Spack to run uninterrupted in background (spack#14682) Cray bugfix: TERM missing while reading default target (spack#15381) Upstreams: don't write metadata directory to upstream DB (spack#15526) Creating versions from urls doesn't modify class attributes (spack#15452) bugfix: fix install_missing_compilers option bug from v0.14.0 (spack#15416) bugfix: installer.py shouldn't be executable (spack#15386) Add function replace_prefix_nullterm for use on mach-o rpaths. (spack#15347) ArchSpec: fix semantics of satisfies when not concrete and strict is true (spack#15319) suite-sparse: fix installation for v5.X (spack#15326) testing: increase installer coverage (spack#15237) bugfix: resolve undefined source_pkg_dir failure (spack#15339) Bugfix: resolve StopIteration message attribute failure (spack#15341) Recover coverage from subprocesses during unit tests (spack#15354) Correct pytest.raises matches to match (spack#15346) bugfix: Add dependents when initializing spec from yaml (spack#15220) Uniquify suffixes added to module names (spack#14920) bugfix: ensure proper dependency handling for package-only installs (spack#15197) Fix for being able to 'spack load' packages that have been renamed. (spack#14348) ... # Conflicts: # .travis.yml # lib/spack/spack/modules/common.py # var/spack/repos/builtin/packages/mofem-cephas/package.py # var/spack/repos/builtin/packages/mofem-fracture-module/package.py # var/spack/repos/builtin/packages/mofem-users-modules/package.py # var/spack/repos/builtin/packages/python/package.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #15449
Before this PR a call to
pkg.url_for_versionwas modifying class attributes determining different results for subsequent calls and an error when theurlswas empty.